Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753158AbbF3XsK (ORCPT ); Tue, 30 Jun 2015 19:48:10 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39664 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467AbbF3XsG (ORCPT ); Tue, 30 Jun 2015 19:48:06 -0400 X-Sasl-enc: CyTrl6MKB1HJ9CfyKt6waZH3ft7W/ISahxaaEzRhdT+7 1435708086 Date: Tue, 30 Jun 2015 16:48:05 -0700 From: Greg KH To: Jeremy White Cc: hdegoede@redhat.com, spice-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP. Message-ID: <20150630234805.GB13573@kroah.com> References: <1435700650-640-1-git-send-email-jwhite@codeweavers.com> <1435700650-640-2-git-send-email-jwhite@codeweavers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435700650-640-2-git-send-email-jwhite@codeweavers.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3391 Lines: 70 On Tue, Jun 30, 2015 at 04:44:10PM -0500, Jeremy White wrote: > This module uses the usbredir protocol and user space tools, > which are used by the SPICE project. > > Signed-off-by: Jeremy White > --- > MAINTAINERS | 6 + > drivers/usb/Kconfig | 2 + > drivers/usb/Makefile | 1 + > drivers/usb/usbredir/Kconfig | 25 + > drivers/usb/usbredir/Makefile | 4 + > drivers/usb/usbredir/README | 20 + > drivers/usb/usbredir/TODO | 12 + > drivers/usb/usbredir/device.c | 327 +++++ > drivers/usb/usbredir/hub.c | 489 ++++++++ > drivers/usb/usbredir/main.c | 100 ++ > drivers/usb/usbredir/redir.c | 535 ++++++++ > drivers/usb/usbredir/rx.c | 40 + > drivers/usb/usbredir/strtok_r.c | 69 + > drivers/usb/usbredir/strtok_r.h | 26 + > drivers/usb/usbredir/sysfs.c | 145 +++ > drivers/usb/usbredir/tx.c | 151 +++ > drivers/usb/usbredir/urb.c | 266 ++++ > drivers/usb/usbredir/usbredir.h | 225 ++++ > drivers/usb/usbredir/usbredirfilter.c | 294 +++++ > drivers/usb/usbredir/usbredirfilter.h | 144 +++ > drivers/usb/usbredir/usbredirparser.c | 1795 +++++++++++++++++++++++++++ > drivers/usb/usbredir/usbredirparser.h | 386 ++++++ > drivers/usb/usbredir/usbredirproto-compat.h | 88 ++ > drivers/usb/usbredir/usbredirproto.h | 309 +++++ > 24 files changed, 5459 insertions(+) > create mode 100644 drivers/usb/usbredir/Kconfig > create mode 100644 drivers/usb/usbredir/Makefile > create mode 100644 drivers/usb/usbredir/README > create mode 100644 drivers/usb/usbredir/TODO > create mode 100644 drivers/usb/usbredir/device.c > create mode 100644 drivers/usb/usbredir/hub.c > create mode 100644 drivers/usb/usbredir/main.c > create mode 100644 drivers/usb/usbredir/redir.c > create mode 100644 drivers/usb/usbredir/rx.c > create mode 100644 drivers/usb/usbredir/strtok_r.c > create mode 100644 drivers/usb/usbredir/strtok_r.h > create mode 100644 drivers/usb/usbredir/sysfs.c > create mode 100644 drivers/usb/usbredir/tx.c > create mode 100644 drivers/usb/usbredir/urb.c > create mode 100644 drivers/usb/usbredir/usbredir.h > create mode 100644 drivers/usb/usbredir/usbredirfilter.c > create mode 100644 drivers/usb/usbredir/usbredirfilter.h > create mode 100644 drivers/usb/usbredir/usbredirparser.c > create mode 100644 drivers/usb/usbredir/usbredirparser.h > create mode 100644 drivers/usb/usbredir/usbredirproto-compat.h > create mode 100644 drivers/usb/usbredir/usbredirproto.h It's pointless to post a patch that you know has problems with it (i.e. it's not even in proper kernel coding style), as it will never be reviewed or even looked at. Please do the most basic of polite things and fix this up before posting things. And really, all in one patch? That too is pretty hard to review... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/