Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754132AbbGACUF (ORCPT ); Tue, 30 Jun 2015 22:20:05 -0400 Received: from mailout.micron.com ([137.201.242.129]:57613 "EHLO mailout.micron.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754115AbbGACTt convert rfc822-to-8bit (ORCPT ); Tue, 30 Jun 2015 22:19:49 -0400 From: =?iso-2022-jp?B?QmVhbiBIdW8gGyRCcDlJTElMGyhCIChiZWFuaHVvKQ==?= To: Mike Looijmans CC: "git@xilinx.com" , "linux-kernel@vger.kernel.org" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "linux-mtd@lists.infradead.org" Subject: RE: [PATCH] mtd: spi-nor: Only set Micron quad-read mode when controller in 4-lane TX mode Thread-Topic: [PATCH] mtd: spi-nor: Only set Micron quad-read mode when controller in 4-lane TX mode Thread-Index: AQHQsya4YM9yt1UYpkuvveLW+sQ/D53F3o1w Date: Wed, 1 Jul 2015 02:19:00 +0000 Message-ID: References: <1435663042-25425-1-git-send-email-mike.looijmans@topic.nl> In-Reply-To: <1435663042-25425-1-git-send-email-mike.looijmans@topic.nl> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.167.84.5] X-TM-AS-Product-Ver: SMEX-11.0.0.4179-8.000.1202-21644.005 X-TM-AS-Result: No--6.949400-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No x-mt-checkinternalsenderrule: True Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1513 Lines: 33 >drivers/mtd/spi-nor/spi-nor.c | 2 ++ > 1 file changed, 2 insertions(+) >diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index e8f6131..10ba94f 100644 >--- a/drivers/mtd/spi-nor/spi-nor.c >+++ b/drivers/mtd/spi-nor/spi-nor.c >@@ -1398,6 +1398,8 @@ static int set_quad_mode(struct spi_nor *nor, struct flash_info *info) > } > return status; > case CFI_MFR_ST: >+ if (!(nor->spi->mode & SPI_TX_QUAD)) >+ return 0; I think, this action should be done before callback set_quad_mode,and add some codes in Spi controller driver.what is more,how do you get spi member in spi_nor?seems no this member. I have one concern that as long as spi nor be configed into quad mode,spi controller must be also immediately Transfer into quad mode, otherwise read status will be fail. But setting spi controller layer(driver/spi/) and configure spi nor layer(driver/mtd/spi-nor) are not the same mtd layer,I found that it's hard to do. But for new structure spi controller(such as driver/mtd/spi-nor/fsl-quadspi.c) is very reasonable.and it can be easy to set spi controller and spi nor into quad mode at the same time. > status = micron_quad_enable(nor); > if (status) { > dev_err(nor->dev, "Micron quad-read not enabled\n"); >-- >1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/