Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbbGACta (ORCPT ); Tue, 30 Jun 2015 22:49:30 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:34267 "EHLO lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751651AbbGACtW (ORCPT ); Tue, 30 Jun 2015 22:49:22 -0400 X-Original-SENDERIP: 165.243.139.167 X-Original-MAILFROM: cleaneye.kim@lge.com From: SungEun Kim To: rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "cleaeye.kim" Subject: [PATCH] PM / Sleep: Use workqueue for user space wakeup sources garbage collector Date: Wed, 1 Jul 2015 11:48:58 +0900 Message-Id: <1435718938-19088-1-git-send-email-cleaneye.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2440 Lines: 80 From: "cleaeye.kim" The synchronous synchronize_rcu in wakeup_source_remove makes user process which writes to /sys/kernel/wake_unlock blocked sometimes. For example, when android eventhub tries to release wakelock, this blocking process can occur, and eventhub can't get input event for a while. Using workqueue instead of direct function call at pm_wake_unlock can prevent this unnecessary delay of an user space process. Signed-off-by: cleaeye.kim --- kernel/power/wakelock.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/kernel/power/wakelock.c b/kernel/power/wakelock.c index 019069c..ea10baa 100644 --- a/kernel/power/wakelock.c +++ b/kernel/power/wakelock.c @@ -17,6 +17,7 @@ #include #include #include +#include #include "power.h" @@ -96,7 +97,7 @@ static inline void wakelocks_lru_most_recent(struct wakelock *wl) list_move(&wl->lru, &wakelocks_lru_list); } -static void wakelocks_gc(void) +static void wakelocks_gc(struct work_struct *work) { struct wakelock *wl, *aux; ktime_t now; @@ -105,6 +106,7 @@ static void wakelocks_gc(void) return; now = ktime_get(); + mutex_lock(&wakelocks_lock); list_for_each_entry_safe_reverse(wl, aux, &wakelocks_lru_list, lru) { u64 idle_time_ns; bool active; @@ -126,12 +128,15 @@ static void wakelocks_gc(void) decrement_wakelocks_number(); } } + mutex_unlock(&wakelocks_lock); wakelocks_gc_count = 0; } + +static DECLARE_WORK(wakelock_work, wakelocks_gc); #else /* !CONFIG_PM_WAKELOCKS_GC */ static inline void wakelocks_lru_add(struct wakelock *wl) {} static inline void wakelocks_lru_most_recent(struct wakelock *wl) {} -static inline void wakelocks_gc(void) {} +static void wakelocks_gc(struct worksturct) {} #endif /* !CONFIG_PM_WAKELOCKS_GC */ static struct wakelock *wakelock_lookup_add(const char *name, size_t len, @@ -260,7 +265,7 @@ int pm_wake_unlock(const char *buf) __pm_relax(&wl->ws); wakelocks_lru_most_recent(wl); - wakelocks_gc(); + schedule_work(&wakelock_work); out: mutex_unlock(&wakelocks_lock); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/