Message-ID: <55935FC1.8090203@codeweavers.com>
Date: Tue, 30 Jun 2015 22:34:25 -0500
From: Jeremy White <jwhite@codeweavers.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0
MIME-Version: 1.0
To: Greg KH <greg@kroah.com>
CC: hdegoede@redhat.com, spice-devel@lists.freedesktop.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect
 USB devices over IP.
References: <1435700650-640-1-git-send-email-jwhite@codeweavers.com> <1435700650-640-2-git-send-email-jwhite@codeweavers.com> <20150630234805.GB13573@kroah.com>
In-Reply-To: <20150630234805.GB13573@kroah.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1354
Lines: 39

>
> It's pointless to post a patch that you know has problems with it (i.e.
> it's not even in proper kernel coding style), as it will never be
> reviewed or even looked at.

Thanks for the reply, and I'm sorry for the clumsy ask.

I would still appreciate feedback on two points:

   1.  Is the basic premise reasonable?  Is Hans correct in asserting 
that an alternate USB over IP module will be considered?

   2.  Do I correctly understand that there are no circumstances where 
copied code can be left unmodified?  Even in the case where the copied 
code is working, production code, and the changes would be just for style?

>
> Please do the most basic of polite things and fix this up before posting
> things.

It is often difficult for a newcomer to know what the polite thing is, 
even after studying FAQs and documentation.

I appreciate your patience (and clue bats) as I try to learn.

>
> And really, all in one patch?  That too is pretty hard to review...

Yeah.  I see the point of pain.  I did not see a solution as I formed 
the patch, but I'll try harder before resending.

Cheers,

Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/