Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752989AbbGAG2V (ORCPT ); Wed, 1 Jul 2015 02:28:21 -0400 Received: from mga02.intel.com ([134.134.136.20]:25444 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbbGAG2M (ORCPT ); Wed, 1 Jul 2015 02:28:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,383,1432623600"; d="scan'208";a="756321340" Message-ID: <559387DF.9050606@intel.com> Date: Wed, 01 Jul 2015 14:25:35 +0800 From: Pan Xinhui User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Frans Klaver CC: "linux-kernel@vger.kernel.org" , Yury Norov , Andrew Morton , Rasmus Villemoes , tj@kernel.org, Peter Zijlstra , sudeep.holla@arm.com, mina86@mina86.com, "mnipxh@163.com" , Alexey Klimov , "yanmin_zhang@linux.intel.com" Subject: Re: [PATCH V2] lib/bitmap.c: fix some parsing issues and code style References: <55935B19.5080103@intel.com> <55936976.7090001@intel.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1560 Lines: 45 hello, Frans thanks for your reply :) On 2015年07月01日 14:17, Frans Klaver wrote: > On Wed, Jul 1, 2015 at 6:15 AM, Pan Xinhui wrote: >> >> In __bitmap_parselist we can accept whitespaces on head or tail >> during every parsing procedure. >> If input has valid ranges, there is no reason to reject the user. >> >> fixes are: >> 1) if input ends with ',', bit 0 might be set unexpectedly. >> now we check if any digit is available after every loop. >> 2) if input has '0-', bit 0 might be set unexpectedly, >> now we return -EINVAL as this kind of input is definitely wrong. >> 3) minor code style fix in __bitmap_parse. >> and avoid in-loop incrementation of ndigits. > > Why not three patches, so it becomes easier to see which is which? > your advice sounds good, I will have a try. and welcome for review. :) thanks. > >> commit 2528a8b also add some check, but it's still not enough. >> it only correct the result in fix 1 above. > > I believe the convention is to have at least 12 characters of the > sha1, with the title behind it: 2528a8b8f457 (__bitmap_parselist: fix > bug in empty string handling). Using only seven characters still risks > collisions. > sorry for my lack knowledge of comment rules. thanks for pointing out my mistakes. thanks xinhui > Thanks, > Frans > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/