Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753116AbbGAHZ7 (ORCPT ); Wed, 1 Jul 2015 03:25:59 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36790 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbbGAHZv (ORCPT ); Wed, 1 Jul 2015 03:25:51 -0400 MIME-Version: 1.0 In-Reply-To: <20150626160549.GA15434@redhat.com> References: <20150626160549.GA15434@redhat.com> Date: Wed, 1 Jul 2015 09:25:49 +0200 X-Google-Sender-Auth: GuZbshQHgrLQ9UQcoqBmiSDwIO4 Message-ID: Subject: Re: DM_CACHE_SMQ is experimental and enabled by default? (was: Re: dm cache: add stochastic-multi-queue (smq) policy) From: Geert Uytterhoeven To: Mike Snitzer Cc: Joe Thornber , linux-raid@vger.kernel.org, Linux Kernel Mailing List , dm-devel@redhat.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1879 Lines: 53 Hi Mike, On Fri, Jun 26, 2015 at 6:05 PM, Mike Snitzer wrote: > On Fri, Jun 26 2015 at 3:47am -0400, > Geert Uytterhoeven wrote: > >> On Fri, Jun 26, 2015 at 2:13 AM, Linux Kernel Mailing List >> wrote: >> > Gitweb: http://git.kernel.org/linus/;a=commit;h=66a636356647a9be8885c2ce2948de126577698a >> > Commit: 66a636356647a9be8885c2ce2948de126577698a >> > >> > dm cache: add stochastic-multi-queue (smq) policy >> >> > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig >> > index edcf4ab..b597273 100644 >> > --- a/drivers/md/Kconfig >> > +++ b/drivers/md/Kconfig >> > @@ -304,6 +304,18 @@ config DM_CACHE_MQ >> > This is meant to be a general purpose policy. It prioritises >> > reads over writes. >> > >> > +config DM_CACHE_SMQ >> > + tristate "Stochastic MQ Cache Policy (EXPERIMENTAL)" >> > + depends on DM_CACHE >> > + default y >> >> A feature cannot be "EXPERIMENTAL", and be enabled by default. >> Please drop (at least) one of them. > > Thanks for your concern, but: no. > > If you look closer the entirety of DM cache is marked EXPERIMENTAL: > > config DM_CACHE > tristate "Cache target (EXPERIMENTAL)" I stand corrected. Sorry for the fuss. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/