Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753448AbbGAHhG (ORCPT ); Wed, 1 Jul 2015 03:37:06 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:22547 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752995AbbGAHgy (ORCPT ); Wed, 1 Jul 2015 03:36:54 -0400 X-Greylist: delayed 36055 seconds by postgrey-1.27 at vger.kernel.org; Wed, 01 Jul 2015 03:36:54 EDT DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; b=GLmHgKgk9BhiDN5k8W3+bTI1TmojmuW4nddXL/iP/MESE0yRwAf9A5u0BJWedv8YT0ZBITNHkZ+y VdkHVIiL4E57reHe/emqXcMohZr1TxpivVMxYrf3T+FckE78X2cy Subject: Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style issue To: Sudip Mukherjee References: <55930BB1.10502@zoho.com> <20150701065749.GA2411@sudip-PC> Cc: benjamin.romer@unisys.com, david.kershner@unisys.com, bryan.thompson@unisys.com, erik.arfvidson@unisys.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, sparmaintainer@unisys.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Sohny Thomas Message-ID: <55939890.6090903@zoho.com> Date: Wed, 1 Jul 2015 13:06:48 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150701065749.GA2411@sudip-PC> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 150630-1, 30-06-2015), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2114 Lines: 69 Thanks for review, my answers inline On 01-07-2015 12:27, Sudip Mukherjee wrote: > On Wed, Jul 01, 2015 at 03:05:45AM +0530, Sohny Thomas wrote: >> >> FIX 2 unnecessary braces found by checkpatch.pl >> >> Signed-off-by: Sohny Thomas >> --- >> drivers/staging/unisys/virtpci/virtpci.c | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/staging/unisys/virtpci/virtpci.c >> index d5ad017..f3674de 100644 >> --- a/drivers/staging/unisys/virtpci/virtpci.c >> +++ b/drivers/staging/unisys/virtpci/virtpci.c >> @@ -190,9 +190,10 @@ static int write_vbus_chp_info(struct spar_vbus_channel_protocol *chan, >> return -1; >> >> off = sizeof(struct channel_header) + chan->hdr_info.chp_info_offset; >> - if (chan->hdr_info.chp_info_offset == 0) { >> + >> + if (chan->hdr_info.chp_info_offset == 0) >> return -1; >> - } >> + > why you are inserting new line here? I did it so that its readable, will remove it if not required > >> memcpy(((u8 *)(chan)) + off, info, sizeof(*info)); >> return 0; >> } >> @@ -484,10 +485,10 @@ static int delete_vhba(struct del_virt_guestpart *delparams) >> >> i = virtpci_device_del(NULL /*no parent bus */, VIRTHBA_TYPE, >> &scsi.wwnn, NULL); >> - if (i) { >> + if (i) >> return 1; >> - } >> - return 0; >> + else >> + return 0; > No, now this will introduce a new checkpatch warning that "else is not > required after return". why did you introduce this "else"? I did this so that the code is more readable and understandable, I checked and checkpatch didn't call this out , so its clean. Otherwise the above code looks like this if(i) return 1; return 0; > > regards > sudip > --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/