Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752467AbbGAHlE (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jul 2015 03:41:04 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:37688 "EHLO
	mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752430AbbGAHk5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jul 2015 03:40:57 -0400
Date: Wed, 1 Jul 2015 08:40:53 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org, pankaj.m@samsung.com
Subject: Re: [PATCH 1/1] mfd: remove unnecessary check
Message-ID: <20150701074053.GC3210@x1>
References: <1435666326-10039-1-git-send-email-maninder1.s@samsung.com>
 <20150701073950.GB3210@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20150701073950.GB3210@x1>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1821
Lines: 55

On Wed, 01 Jul 2015, Lee Jones wrote:
> On Tue, 30 Jun 2015, Maninder Singh wrote:
> 
> >  o Making pdata NULL check to (!pdata) as coding statndard
> > 	and all other checks in file.
> >  o Removing redundant check of pdata, because we already
> > 	check for pdata, and also derefernced before this check
> > 
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> > ---
> >  drivers/mfd/t7l66xb.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied, with a properly formatted subject line.

Should have probably been more forthcomming with some advice.

Next time, please use `git log --oneline -- <subsystem>` to see what
the accepted format is.

> > diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
> > index c09fb5d..854b05f 100644
> > --- a/drivers/mfd/t7l66xb.c
> > +++ b/drivers/mfd/t7l66xb.c
> > @@ -318,7 +318,7 @@ static int t7l66xb_probe(struct platform_device *dev)
> >  	struct resource *iomem, *rscr;
> >  	int ret;
> >  
> > -	if (pdata == NULL)
> > +	if (!pdata)
> >  		return -EINVAL;
> >  
> >  	iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
> > @@ -371,7 +371,7 @@ static int t7l66xb_probe(struct platform_device *dev)
> >  
> >  	clk_prepare_enable(t7l66xb->clk48m);
> >  
> > -	if (pdata && pdata->enable)
> > +	if (pdata->enable)
> >  		pdata->enable(dev);
> >  
> >  	/* Mask all interrupts */
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/