Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753138AbbGAHqO (ORCPT ); Wed, 1 Jul 2015 03:46:14 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38258 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbbGAHqG (ORCPT ); Wed, 1 Jul 2015 03:46:06 -0400 Date: Wed, 1 Jul 2015 08:46:01 +0100 From: Lee Jones To: Shobhit Kumar Cc: linux-pwm , intel-gfx , linux-kernel , dri-devel , linux-gpio , Paul Bolle , Jani Nikula , Samuel Ortiz , Alexandre Courbot , David Airlie , Povilas Staniulis , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Linus Walleij , Paul Gortmaker , bloften80@gmail.com, varkabhadram@gmail.com Subject: Re: [v3 1/7] gpiolib: Add support for removing registered consumer lookup table Message-ID: <20150701074601.GE3210@x1> References: <1435309330-50725-1-git-send-email-shobhit.kumar@intel.com> <1435309330-50725-2-git-send-email-shobhit.kumar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1435309330-50725-2-git-send-email-shobhit.kumar@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2482 Lines: 70 On Fri, 26 Jun 2015, Shobhit Kumar wrote: > In case we unload and load a driver module again that is registering a > lookup table, without this it will result in multiple entries. Provide > an option to remove the lookup table on driver unload > > Cc: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Reviewed-by: Alexandre Courbot > Reviewed-by: Linus Walleij > Tested-by: Ville Syrjälä > Signed-off-by: Shobhit Kumar > --- > v2: Ccing maintainers > v3: Correct the subject line (Lee jones) Acked-by: Lee Jones > drivers/gpio/gpiolib.c | 13 +++++++++++++ > include/linux/gpio/machine.h | 1 + > 2 files changed, 14 insertions(+) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 957ede5..9d3ea4e 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -1675,6 +1675,19 @@ void gpiod_add_lookup_table(struct gpiod_lookup_table *table) > mutex_unlock(&gpio_lookup_lock); > } > > +/** > + * gpiod_remove_lookup_table() - unregister GPIO device consumers > + * @table: table of consumers to unregister > + */ > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table) > +{ > + mutex_lock(&gpio_lookup_lock); > + > + list_del(&table->list); > + > + mutex_unlock(&gpio_lookup_lock); > +} > + > static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, > unsigned int idx, > enum gpio_lookup_flags *flags) > diff --git a/include/linux/gpio/machine.h b/include/linux/gpio/machine.h > index e270614..c0d712d 100644 > --- a/include/linux/gpio/machine.h > +++ b/include/linux/gpio/machine.h > @@ -57,5 +57,6 @@ struct gpiod_lookup_table { > } > > void gpiod_add_lookup_table(struct gpiod_lookup_table *table); > +void gpiod_remove_lookup_table(struct gpiod_lookup_table *table); > > #endif /* __LINUX_GPIO_MACHINE_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/