Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752649AbbGAH7T (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jul 2015 03:59:19 -0400
Received: from mail-vn0-f44.google.com ([209.85.216.44]:41818 "EHLO
	mail-vn0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751170AbbGAH7L (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jul 2015 03:59:11 -0400
MIME-Version: 1.0
In-Reply-To: <20150701074053.GC3210@x1>
References: <1435666326-10039-1-git-send-email-maninder1.s@samsung.com>
	<20150701073950.GB3210@x1>
	<20150701074053.GC3210@x1>
Date: Wed, 1 Jul 2015 16:59:11 +0900
X-Google-Sender-Auth: BXwzt7niGiym5Zp3t2HA8STZys0
Message-ID: <CAJKOXPdp_zjozfjjtXJ19GojGfkvnzsStdhhji_m3MeVCfc+Aw@mail.gmail.com>
Subject: Re: [PATCH 1/1] mfd: remove unnecessary check
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Maninder Singh <maninder1.s@samsung.com>, sameo@linux.intel.com,
        linux-kernel@vger.kernel.org, pankaj.m@samsung.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1269
Lines: 33

2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> On Wed, 01 Jul 2015, Lee Jones wrote:
>> On Tue, 30 Jun 2015, Maninder Singh wrote:
>>
>> >  o Making pdata NULL check to (!pdata) as coding statndard
>> >     and all other checks in file.
>> >  o Removing redundant check of pdata, because we already
>> >     check for pdata, and also derefernced before this check
>> >
>> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> > ---
>> >  drivers/mfd/t7l66xb.c |    4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Applied, with a properly formatted subject line.
>
> Should have probably been more forthcomming with some advice.
>
> Next time, please use `git log --oneline -- <subsystem>` to see what
> the accepted format is.

... and a spell-check could be useful as well :). The reviewed-by tag
was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
so I think it should be dropped.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/