Date: Wed, 1 Jul 2015 09:02:16 +0100
From: Lee Jones <lee.jones@linaro.org>
To: "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
Cc: LINUXKERNEL <linux-kernel@vger.kernel.org>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        DEVICETREE <devicetree@vger.kernel.org>,
        David Dajun Chen <david.chen@diasemi.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        LINUXINPUT <linux-input@vger.kernel.org>,
        LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Pawel Moll <pawel.moll@arm.com>,
        RTCLINUX <rtc-linux@googlegroups.com>,
        Rob Herring <robh+dt@kernel.org>,
        Support Opensource <Support.Opensource@diasemi.com>,
        Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver
Message-ID: <20150701080216.GF3210@x1>
References: <cover.1432041031.git.stwiss.opensource@diasemi.com>
 <ecf72b79429e6758111a908fd1ded29c0b96da15.1432041031.git.stwiss.opensource@diasemi.com>
 <20150526161024.GQ11677@x1>
 <6ED8E3B22081A4459DAC7699F3695FB7014B22F4C4@SW-EX-MBX02.diasemi.com>
 <20150611085653.GG2982@x1>
 <6ED8E3B22081A4459DAC7699F3695FB7014B233463@SW-EX-MBX02.diasemi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6ED8E3B22081A4459DAC7699F3695FB7014B233463@SW-EX-MBX02.diasemi.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1860
Lines: 50

On Mon, 29 Jun 2015, Opensource [Steve Twiss] wrote:

> On 11 June 2015 09:57, Lee Jones wrote:
> 
> > To: Opensource [Steve Twiss]
> > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver
> > 
> > > > > > Steve Twiss wrote:
> > > > > > +#define DA9062AA_PAGE_SHIFT		0
> > > > > > +#define DA9062AA_PAGE_MASK		(0x3f << 0)
> > > > > > +#define DA9062AA_WRITE_MODE_SHIFT	6
> > > > > > +#define DA9062AA_WRITE_MODE_MASK	(0x01 << 6)
> > > > >
> > > > > Lee Jones wrote:
> > > > > For 1 << X, you should use BIT(X).
> > > >
> > > > Steve Twiss wrote:
> > > > The whole of this file is automatically generated by our hardware designers
> > > > I would prefer it if the register definitions and bit fields are not altered [...]
> 
> [...]
> 
> > Lee Jones wrote:
> > To be honest, it's probably not a blocker for acceptance, but if someone
> > writes a patch next week to change all of the (0x01 << X) lines to
> > start using the BIT() macro, I will accept it.  Better to influenced
> > your guys so you are not overly inconvenienced.
> > FWIW, when upstreaming code, the excuse "someone else wrote it", has
> > never been a good one to use on the lists.   Believe me, I've
> > tried. ;)
> 
> Hi Lee,
> 
> Depending on your next step ..
> I can either send a patch to this now or wait until you have reviewed the MFD
> core: if there are any further comments on this, I can update the submission
> retrospectively.

Let's start over.  Please re-submit the set.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/