Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753057AbbGAIDO (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jul 2015 04:03:14 -0400
Received: from mail-pa0-f43.google.com ([209.85.220.43]:35688 "EHLO
	mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753194AbbGAICu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jul 2015 04:02:50 -0400
Date: Wed, 1 Jul 2015 13:32:42 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Sohny Thomas <sohnythomas@zoho.com>
Cc: benjamin.romer@unisys.com, david.kershner@unisys.com,
        bryan.thompson@unisys.com, erik.arfvidson@unisys.com,
        devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        sparmaintainer@unisys.com, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style
 issue
Message-ID: <20150701080242.GD2411@sudip-PC>
References: <55930BB1.10502@zoho.com>
 <20150701065749.GA2411@sudip-PC>
 <55939890.6090903@zoho.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55939890.6090903@zoho.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 851
Lines: 24

On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
<snip>
> >No, now this will introduce a new checkpatch warning that "else is not
> >required after return". why did you introduce this "else"?
> I did this so that the code is more readable and understandable, I
> checked and checkpatch didn't call this out , so its clean.
> 
> Otherwise the above code looks like this
> 
> if(i)
>    return 1;
> return 0;
you should update your tree. virtpci folder has been deleted from
unisys driver.
As you are using an old tree, maybe that explains why checkpatch is not
giving the error.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/