Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435AbbGAIFj (ORCPT ); Wed, 1 Jul 2015 04:05:39 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:35414 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbbGAIFW (ORCPT ); Wed, 1 Jul 2015 04:05:22 -0400 Message-ID: <55939F3E.7070505@cumulusnetworks.com> Date: Wed, 01 Jul 2015 01:05:18 -0700 From: Ellen Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antonio Borneo , Jiri Kosina , linux-input@vger.kernel.org CC: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH] HID: cp2112: fix to force single data-report reply References: <1434867625-3062-1-git-send-email-borneo.antonio@gmail.com> In-Reply-To: <1434867625-3062-1-git-send-email-borneo.antonio@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1634 Lines: 47 Works as described. Thank you! By the way, I tested the code with and without your fix on my rev 2 chip, and it behaved the same way as you describe on your rev 1 chip. On 06/20/2015 11:20 PM, Antonio Borneo wrote: > Current implementation of cp2112_raw_event() only accepts one data > report at a time. If last received data report is not fully handled > yet, a new incoming data report will overwrite it. In such case we > don't guaranteed to propagate the correct incoming data. > > The trivial fix implemented here forces a single report at a time > by requesting in cp2112_read() no more than 61 byte of data, which > is the payload size of a single data report. > > Signed-off-by: Antonio Borneo > --- > > Hi Jiri, > > I think this should go through linux-stable. > > Thanks, > Antonio > > drivers/hid/hid-cp2112.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c > index 3318de6..a2dbbbe 100644 > --- a/drivers/hid/hid-cp2112.c > +++ b/drivers/hid/hid-cp2112.c > @@ -356,6 +356,8 @@ static int cp2112_read(struct cp2112_device *dev, u8 *data, size_t size) > struct cp2112_force_read_report report; > int ret; > > + if (size > sizeof(dev->read_data)) > + size = sizeof(dev->read_data); > report.report = CP2112_DATA_READ_FORCE_SEND; > report.length = cpu_to_be16(size); > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/