Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974AbbGAIUh (ORCPT ); Wed, 1 Jul 2015 04:20:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50801 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbbGAIUU (ORCPT ); Wed, 1 Jul 2015 04:20:20 -0400 Date: Wed, 1 Jul 2015 10:20:15 +0200 From: Jan Kara To: Tejun Heo Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, jack@suse.cz, hch@infradead.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.cz, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com, khlebnikov@yandex-team.ru, "Theodore Ts'o" Subject: Re: [PATCH 42/51] writeback: make wakeup_dirtytime_writeback() handle multiple bdi_writeback's Message-ID: <20150701082015.GC7252@quack.suse.cz> References: <1432329245-5844-1-git-send-email-tj@kernel.org> <1432329245-5844-43-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432329245-5844-43-git-send-email-tj@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1509 Lines: 51 On Fri 22-05-15 17:13:56, Tejun Heo wrote: > wakeup_dirtytime_writeback() currently only starts writeback on the > root wb (bdi_writeback). For cgroup writeback support, update the > function to check all wbs. > > Signed-off-by: Tejun Heo > Cc: Jens Axboe > Cc: Jan Kara > Cc: Theodore Ts'o Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/fs-writeback.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 508e10c..8ae212e 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -1260,9 +1260,12 @@ static void wakeup_dirtytime_writeback(struct work_struct *w) > > rcu_read_lock(); > list_for_each_entry_rcu(bdi, &bdi_list, bdi_list) { > - if (list_empty(&bdi->wb.b_dirty_time)) > - continue; > - wb_wakeup(&bdi->wb); > + struct bdi_writeback *wb; > + struct wb_iter iter; > + > + bdi_for_each_wb(wb, bdi, &iter, 0) > + if (!list_empty(&bdi->wb.b_dirty_time)) > + wb_wakeup(&bdi->wb); > } > rcu_read_unlock(); > schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ); > -- > 2.4.0 > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/