Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753529AbbGAIfI (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jul 2015 04:35:08 -0400
Received: from sender153-mail.zoho.com ([74.201.84.153]:22671 "EHLO
	sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751052AbbGAIe7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jul 2015 04:34:59 -0400
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; 
  s=zapps768; d=zoho.com; 
  h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; 
  b=l9ILGhVAUPgNMT1sezysZBtivEizxmm+XxnGQnc5EmvQRvpoCzdtTIMlmam/0wEX9L4UcfCnTJzV
    ZDa8SRQbeAzMuQr5QVa5g9E80FA5QD7+4AdOg+FCxAxv/bXNgJ0L  
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed a brace coding style
 issue
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
References: <55930BB1.10502@zoho.com> <20150701065749.GA2411@sudip-PC>
 <55939890.6090903@zoho.com> <20150701080242.GD2411@sudip-PC>
Cc: benjamin.romer@unisys.com, david.kershner@unisys.com,
        bryan.thompson@unisys.com, erik.arfvidson@unisys.com,
        devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        sparmaintainer@unisys.com, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Sohny Thomas <sohnythomas@zoho.com>
Message-ID: <5593A628.1060008@zoho.com>
Date: Wed, 1 Jul 2015 14:04:48 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <20150701080242.GD2411@sudip-PC>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1048
Lines: 31



On Wednesday 01 July 2015 01:32 PM, Sudip Mukherjee wrote:
> On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote:
> <snip>
>>> No, now this will introduce a new checkpatch warning that "else is not
>>> required after return". why did you introduce this "else"?
>> I did this so that the code is more readable and understandable, I
>> checked and checkpatch didn't call this out , so its clean.
>>
>> Otherwise the above code looks like this
>>
>> if(i)
>>    return 1;
>> return 0;
> you should update your tree. virtpci folder has been deleted from
> unisys driver.
> As you are using an old tree, maybe that explains why checkpatch is not
> giving the error.

This is from linux-stable branch and I updated  it just yesterday, so looks like the folders still there
> 
> regards
> sudip
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/