Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751500AbbGAIpA (ORCPT ); Wed, 1 Jul 2015 04:45:00 -0400 Received: from fish.king.net.pl ([79.190.246.46]:57719 "EHLO king.net.pl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750768AbbGAIor (ORCPT ); Wed, 1 Jul 2015 04:44:47 -0400 Date: Wed, 1 Jul 2015 10:42:07 +0200 (CEST) From: Paul Osmialowski X-X-Sender: newchief@localhost.localdomain To: Thomas Gleixner cc: Paul Osmialowski , Greg Kroah-Hartman , Ian Campbell , Jiri Slaby , Kumar Gala , Linus Walleij , Mark Rutland , Michael Turquette , Pawel Moll , Rob Herring , Russell King , Stephen Boyd , Vinod Koul , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Arnd Bergmann , Geert Uytterhoeven , Nicolas Pitre , Paul Bolle , Uwe Kleine-Koenig , Anson Huang , Frank Li , Jingchang Lu , Rob Herring , Yuri Tikhonov , Sergei Poselenov , Alexander Potashev Subject: Re: [PATCH v2 4/9] arm: twr-k70f120m: timer driver for Kinetis SoC In-Reply-To: Message-ID: References: <1435667250-28299-1-git-send-email-pawelo@king.net.pl> <1435667250-28299-5-git-send-email-pawelo@king.net.pl> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 809 Lines: 23 Hi Thomas, On Wed, 1 Jul 2015, Thomas Gleixner wrote: >> + clockevents_register_device( >> + &kinetis_clockevent_tmrs[chan].evtdev); >> + >> + kinetis_pit_init(&kinetis_clockevent_tmrs[chan], >> + (rate / HZ) - 1); >> + kinetis_pit_enable(&kinetis_clockevent_tmrs[chan], 1); > > No point doing this. The core code has invoked the set_periodic call > back via clockevents_register_device() already. > As I removed this kinetis_pit_enable() line, the timer did not start, therefore the system became unusable. What could be possible reason for that? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/