Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbbGAIxZ (ORCPT ); Wed, 1 Jul 2015 04:53:25 -0400 Received: from mta-out1.inet.fi ([62.71.2.230]:40965 "EHLO johanna1.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbbGAIxQ (ORCPT ); Wed, 1 Jul 2015 04:53:16 -0400 RazorGate-KAS: Rate: 5 RazorGate-KAS: {RECEIVED: dynamic ip detected} RazorGate-KAS: Envelope from: RazorGate-KAS: Version: 5.5.3 RazorGate-KAS: LuaCore: 80 2014-11-10_18-01-23 260f8afb9361da3c7edfd3a8e3a4ca908191ad29 RazorGate-KAS: Method: none RazorGate-KAS: Lua profiles 69136 [Nov 12 2014] RazorGate-KAS: Status: not_detected Date: Wed, 1 Jul 2015 11:53:04 +0300 From: "Kirill A. Shutemov" To: David Rientjes Cc: Sasha Levin , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/11] mm: debug: dump page into a string rather than directly on screen Message-ID: <20150701085304.GA18268@node.dhcp.inet.fi> References: <1431623414-1905-1-git-send-email-sasha.levin@oracle.com> <1431623414-1905-6-git-send-email-sasha.levin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 34 On Tue, Jun 30, 2015 at 04:35:45PM -0700, David Rientjes wrote: > I do understand the problem with the current VM_BUG_ON_PAGE() and > VM_BUG_ON_VMA() stuff, and it compels me to ask about just going back to > the normal > > VM_BUG_ON(cond); > > coupled with dump_page(), dump_vma(), dump_whatever(). It all seems so > much simpler to me. Is there a sensible way to couple them? I don't see much, except opencode VM_BUG_ON(): if (IS_ENABLED(CONFIG_DEBUG_VM) && cond) { dump_page(...); dump_vma(...); dump_whatever(); BUG(); } That's too verbose to me to be usable. BTW, I also tried[1] to solve this problem too, but people doesn't like either. [1] http://lkml.kernel.org/g/1412163121-4295-1-git-send-email-kirill.shutemov@linux.intel.com -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/