Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753180AbbGAJHB (ORCPT ); Wed, 1 Jul 2015 05:07:01 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:8716 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbbGAJGY (ORCPT ); Wed, 1 Jul 2015 05:06:24 -0400 From: He Kuang To: , , , , , CC: , Subject: [PATCH 1/4] perf record: Use %ld for long type sample counter Date: Wed, 1 Jul 2015 09:05:36 +0000 Message-ID: <1435741539-44100-1-git-send-email-hekuang@huawei.com> X-Mailer: git-send-email 1.8.3.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.197.210] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 49 Since we post-process and count (long rec->samples) to show precise number of samples instead of estimate on (u64 rec->bytes_written), the format string of that should be changed to %ld accordingly, otherwise the value don't show right on 32bit machine. Before this patch: $ perf record -e syscalls:sys_enter_write -- dd if=/dev/zero of=/dev/null bs=4k count=1000 1000+0 records in 1000+0 records out [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.077 MB perf.data (1 samples) ] After this patch: $ perf record -e syscalls:sys_enter_write -- dd if=/dev/zero of=/dev/null bs=4k count=1000 1000+0 records in 1000+0 records out [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.077 MB perf.data (1001 samples) ] Signed-off-by: He Kuang --- tools/perf/builtin-record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index de165a1..65e632d 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -737,7 +737,7 @@ out_child: if (rec->samples && !rec->opts.full_auxtrace) scnprintf(samples, sizeof(samples), - " (%" PRIu64 " samples)", rec->samples); + " (%ld samples)", rec->samples); else samples[0] = '\0'; -- 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/