Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754362AbbGAJqK (ORCPT ); Wed, 1 Jul 2015 05:46:10 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:34739 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753953AbbGAJng (ORCPT ); Wed, 1 Jul 2015 05:43:36 -0400 Date: Wed, 1 Jul 2015 10:42:58 +0100 From: Mark Brown To: Sakari Ailus Cc: Jacek Anaszewski , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, stsp@users.sourceforge.net, pavel@ucw.cz, sakari.ailus@linux.intel.com, andreas.werner@men.de, andrew@lunn.ch, ospite@studenti.unina.it, anemo@mba.ocn.ne.jp, ben@simtec.co.uk, bootc@bootc.net, dmurphy@ti.com, daniel.jeong@ti.com, daniel@zonque.org, davem@davemloft.net, fabio.baltieri@gmail.com, balbi@ti.com, florian@openwrt.org, gshark.jeong@gmail.com, g.liakhovetski@gmx.de, ingi2.kim@samsung.com, dl9pf@gmx.de, johan@kernel.org, lenz@cs.wisc.edu, jogo@openwrt.org, q1.kim@samsung.com, kris@krisk.org, kristoffer.ericson@gmail.com, linus.walleij@linaro.org, michael.hennerich@analog.com, milo.kim@ti.com, nm127@freemail.hu, ncase@xes-inc.com, neilb@suse.de, nick.forbes@incepta.com, lost.distance@yahoo.com, p.meerwald@bct-electronic.com, n0-1@freewrt.org, philippe.retornaz@epfl.ch, raph@8d.com, rpurdie@openedhand.com, rod@whitby.id.au, dave@sr71.net, giometti@linux.it, bigeasy@linutronix.de, shuahkhan@gmail.com, sguinot@lacie.com Message-ID: <20150701094258.GS11162@sirena.org.uk> References: <1435672770-4261-1-git-send-email-j.anaszewski@samsung.com> <20150630222450.GR5904@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uNvczuo8OWfsyO2w" Content-Disposition: inline In-Reply-To: <20150630222450.GR5904@valkosipuli.retiisi.org.uk> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for brightness_set ops that can sleep X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1400 Lines: 38 --uNvczuo8OWfsyO2w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 01, 2015 at 01:24:50AM +0300, Sakari Ailus wrote: > The documentation should be improved to tell how the API is expected to be > have, e.g. which functions may block. I think this is out of scope for this > patch though. > I think all the existing drivers that implement the set_brightness() > callback have a fast (and non-blocking) implementation, and some of these Yes, they need to be since triggers can happen in any context. --uNvczuo8OWfsyO2w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVk7YhAAoJECTWi3JdVIfQ3OYH/RQtZW9ymtugHgQ8PoWZr1K5 Hj8pakgYu95XjLjFTPOJRxsgCQCdLD7/cooPbf9EIXtPdyVvSIjm6RwHjXLeUx9F LB2IyZKYyZ+dOOC8ZRjY3PvL6LpTrF3yUq4Uvb+HiTbi1RdhSWkYTNJo2bUvXJod IMpwL6ti6eFPD9YDyGVocBAKKtQNLCCWs3muXt0Hbt9569s9jt50WCkDSlrlsT24 gwJzMC5DdOtwKliEzrz9kEvmsORFjfPckAKCb4mv2xomnZKRsBMmOIOgwdYnBBcT dw6DVEN+2EAaEAXbdm4XQUUpSmaLIcNFWqSEwQ3gd4gjB42ScRSWHUNLthuT1l4= =KEuz -----END PGP SIGNATURE----- --uNvczuo8OWfsyO2w-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/