Message-id: <5593C526.9070300@samsung.com>
Date: Wed, 01 Jul 2015 12:47:02 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Pavel Machek <pavel@denx.de>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
        Stas Sergeev <stsp@users.sourceforge.net>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Andreas Werner <andreas.werner@men.de>, Andrew Lunn <andrew@lunn.ch>,
        Antonio Ospite <ospite@studenti.unina.it>,
        Atsushi Nemoto <anemo@mba.ocn.ne.jp>, Ben Dooks <ben@simtec.co.uk>,
        Chris Boot <bootc@bootc.net>, Dan Murphy <dmurphy@ti.com>,
        Daniel Jeong <daniel.jeong@ti.com>, Daniel Mack <daniel@zonque.org>,
        "David S. Miller" <davem@davemloft.net>,
        Fabio Baltieri <fabio.baltieri@gmail.com>, Felipe Balbi <balbi@ti.com>,
        Florian Fainelli <florian@openwrt.org>,
        "G.Shark Jeong" <gshark.jeong@gmail.com>,
        Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
        Ingi Kim <ingi2.kim@samsung.com>, Jan-Simon Moeller <dl9pf@gmx.de>,
        Johan Hovold <johan@kernel.org>, John Lenz <lenz@cs.wisc.edu>,
        Jonas Gorski <jogo@openwrt.org>, Kim Kyuwon <q1.kim@samsung.com>,
        Kristian Kielhofner <kris@krisk.org>,
        Kristoffer Ericson <kristoffer.ericson@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Michael Hennerich <michael.hennerich@analog.com>,
        Milo Kim <milo.kim@ti.com>,
        =?ISO-8859-1?Q?M=E1rton_N=E9meth?= <nm127@freemail.hu>,
        Nate Case <ncase@xes-inc.com>, NeilBrown <neilb@suse.de>,
        Nick Forbes <nick.forbes@incepta.com>,
        Paul Parsons <lost.distance@yahoo.com>,
        Peter Meerwald <p.meerwald@bct-electronic.com>,
        Phil Sutter <n0-1@freewrt.org>,
        Philippe Retornaz <philippe.retornaz@epfl.ch>,
        Raphael Assenat <raph@8d.com>, Richard Purdie <rpurdie@openedhand.com>,
        Rod Whitby <rod@whitby.id.au>, Dave Hansen <dave@sr71.net>,
        Rodolfo Giometti <giometti@linux.it>,
        "Sebastian A. Siewior" <bigeasy@linutronix.de>,
        Shuah Khan <shuahkhan@gmail.com>, Simon Guinot <sguinot@lacie.com>,
        =?ISO-8859-1?Q?=C1lvaro_Fern=E1ndez_Rojas?= <noltari@gmail.com>
Subject: Re: [PATCH/RFC RESEND] leds: Use set_brightness_work for
 brightness_set ops that can sleep
References: <1435651268-9657-1-git-send-email-j.anaszewski@samsung.com>
 <20150630115809.GA13605@amd> <5592944B.5020809@samsung.com>
 <20150630174619.GA1852@amd> <559396B4.9020504@samsung.com>
 <20150701074327.GB11385@amd>
In-reply-to: <20150701074327.GB11385@amd>
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2728
Lines: 60

On 07/01/2015 09:43 AM, Pavel Machek wrote:
> On Wed 2015-07-01 09:28:52, Jacek Anaszewski wrote:
>> On 06/30/2015 07:46 PM, Pavel Machek wrote:
>>> On Tue 2015-06-30 15:06:19, Jacek Anaszewski wrote:
>>>> On 06/30/2015 01:58 PM, Pavel Machek wrote:
>>>>> On Tue 2015-06-30 10:01:08, Jacek Anaszewski wrote:
>>>>>> This patch rearranges the core LED subsystem code, so that it
>>>>>> now removes from drivers the responsibility of using work queues
>>>>>> internally in case their brightness_set ops can sleep.
>>>>>> Addition of two flags: LED_BRIGHTNESS_FAST and LED_BLINK_DISABLE
>>>>>> as well as new_brightness_value property to the struct led_classdev
>>>>>> allows for employing existing set_brightness_work to do the job.
>>>>>> The modifications allow also to get rid of brightness_set_sync op,
>>>>>> as flash LED devices can now be handled properly only basing on the
>>>>>> SET_BRIGHTNESS_SYNC flag.
>>>>>
>>>>> Are you sure this is good idea?
>>>>>
>>>>> You'll now use single callback for blocking and non-blocking
>>>>> behaviour. I'm pretty sure stuff like lockdep will have some fun with
>>>>> that.
>>>>
>>>> I enabled "Lock Debugging" options and didn't get any warning.
>>>> Could you describe the use case you are thinking of?
>>>
>>> You may get one when one of the sleeping functions uses some lock...
>>
>> Drivers which use spin_lock in their brightness_set op will have to
>> set LED_BRIGHTNESS_FAST flag, which will instruct the LED core to
>> call the op synchronously. On the other hand drivers which can sleep
>> in their brightness_set op won't set the flag, which will make LED core
>> delegating the op to the work queue task. It is also possible that
>> driver with brightness_set op that can sleep set SET_BRIGHTNESS_SYNC
>> flag - then LED core will call it in a synchronous way from
>> led_brightness_set and it will schedule work queue task in case
>> the op is called from triggers.
>
> I understand this "works".
>
>> If you want to NAK the patch, please come up with detailed analysis
>> on how it can cause problems. Without this I infer that you didn't
>> spend a second on analyzing the code. This is counterproductive.
>
> NAK.
>
> Because calling two functions with different semantics through same
> function pointer is extremely ugly, and _will_ cause lockdep
> problems. Talk to the lockdep people for details.

Which two functions are you thinking of? There is a single
brightness_set op to call.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/