Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753438AbbGAM3p (ORCPT ); Wed, 1 Jul 2015 08:29:45 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35635 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbbGAM3h (ORCPT ); Wed, 1 Jul 2015 08:29:37 -0400 MIME-Version: 1.0 In-Reply-To: <5593DB7F.9090206@zoho.com> References: <5593D55C.5090108@zoho.com> <5593DB7F.9090206@zoho.com> Date: Wed, 1 Jul 2015 14:29:36 +0200 Message-ID: Subject: Re: [PATCH] Staging: android: fix coding style and TODO file From: Frans Klaver To: Sohny Thomas Cc: Greg KH , arve@android.com, riandrews@android.com, sumit.semwal@linaro.org, carlos@cgarcia.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 29 On Wed, Jul 1, 2015 at 2:22 PM, Sohny Thomas wrote: > > > On Wednesday 01 July 2015 05:37 PM, Frans Klaver wrote: >> On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote: >>> - removed non-existant issue from TODO file >> >> s,existant,existent, > Thanks missed that >> >>> kuid_t or uid_t not present in staging/android >>> - fixed 80 char limit exceeding line >>> - a newline after decelartions as per checkpatch.pl >>> - fixed an unnecessary typedef as reported by checkpatch.pl >> >> Fix one issue per patch, please. > Since these were all simple Fixes of about 1/2 lines , I thought to make a single patch. They are simple fixes, but a reviewer still has to figure out what comment belongs to which code change. Since there's no reason for these changes to be atomic, you might as well split them up to make reviewing easier. Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/