Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbbGAMiv (ORCPT ); Wed, 1 Jul 2015 08:38:51 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:22961 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182AbbGAMin (ORCPT ); Wed, 1 Jul 2015 08:38:43 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; b=VYUljaZCQsrQVuESlDJWDuo//CY49eMe/TMfqdvck8Fa/GLWykt1eOk0gsNf3jstOMOr76yZMjTz Qe9P/AiSGTdfzVHnzcJ0emL0y2NGm8PzCW9wf5Hu1F8pKI6y5F7q Subject: Re: [PATCH] Staging: android: fix coding style and TODO file To: Frans Klaver References: <5593D55C.5090108@zoho.com> <5593DB7F.9090206@zoho.com> Cc: Greg KH , arve@android.com, riandrews@android.com, sumit.semwal@linaro.org, carlos@cgarcia.org, "linux-kernel@vger.kernel.org" From: Sohny Thomas Message-ID: <5593DF3E.3030206@zoho.com> Date: Wed, 1 Jul 2015 18:08:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 44 On Wednesday 01 July 2015 05:59 PM, Frans Klaver wrote: > On Wed, Jul 1, 2015 at 2:22 PM, Sohny Thomas wrote: >> >> >> On Wednesday 01 July 2015 05:37 PM, Frans Klaver wrote: >>> On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote: >>>> - removed non-existant issue from TODO file >>> >>> s,existant,existent, >> Thanks missed that >>> >>>> kuid_t or uid_t not present in staging/android >>>> - fixed 80 char limit exceeding line >>>> - a newline after decelartions as per checkpatch.pl >>>> - fixed an unnecessary typedef as reported by checkpatch.pl >>> >>> Fix one issue per patch, please. >> Since these were all simple Fixes of about 1/2 lines , I thought to make a single patch. > > They are simple fixes, but a reviewer still has to figure out what > comment belongs to which code change. Since there's no reason for > these changes to be atomic, you might as well split them up to make > reviewing easier. > Yeap, V2 coming with changes and fixes Sudip's catch too. Thanks for your time. -Sohny > Frans > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/