Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754349AbbGAOIu (ORCPT <rfc822;w@1wt.eu>);
	Wed, 1 Jul 2015 10:08:50 -0400
Received: from mail-wg0-f44.google.com ([74.125.82.44]:34788 "EHLO
	mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753444AbbGAOIb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 1 Jul 2015 10:08:31 -0400
Date: Wed, 1 Jul 2015 15:08:26 +0100
From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Maninder Singh <maninder1.s@samsung.com>, sameo@linux.intel.com,
        linux-kernel@vger.kernel.org, pankaj.m@samsung.com
Subject: Re: [PATCH 1/1] mfd: remove unnecessary check
Message-ID: <20150701140826.GM3210@x1>
References: <1435666326-10039-1-git-send-email-maninder1.s@samsung.com>
 <20150701073950.GB3210@x1>
 <20150701074053.GC3210@x1>
 <CAJKOXPdp_zjozfjjtXJ19GojGfkvnzsStdhhji_m3MeVCfc+Aw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJKOXPdp_zjozfjjtXJ19GojGfkvnzsStdhhji_m3MeVCfc+Aw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1522
Lines: 40

On Wed, 01 Jul 2015, Krzysztof Kozlowski wrote:

> 2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> > On Wed, 01 Jul 2015, Lee Jones wrote:
> >> On Tue, 30 Jun 2015, Maninder Singh wrote:
> >>
> >> >  o Making pdata NULL check to (!pdata) as coding statndard
> >> >     and all other checks in file.
> >> >  o Removing redundant check of pdata, because we already
> >> >     check for pdata, and also derefernced before this check
> >> >
> >> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> >> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> >> > ---
> >> >  drivers/mfd/t7l66xb.c |    4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> Applied, with a properly formatted subject line.
> >
> > Should have probably been more forthcomming with some advice.
> >
> > Next time, please use `git log --oneline -- <subsystem>` to see what
> > the accepted format is.
> 
> ... and a spell-check could be useful as well :). The reviewed-by tag
> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
> so I think it should be dropped.

Fair points.  Patch dropped.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/