Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbbGAOMj (ORCPT ); Wed, 1 Jul 2015 10:12:39 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:40944 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbbGAOMd (ORCPT ); Wed, 1 Jul 2015 10:12:33 -0400 Date: Wed, 1 Jul 2015 15:12:12 +0100 From: Russell King - ARM Linux To: Vitaly Andrianov Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ssantosh@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org Subject: Re: [PATCH] ARM: psci: keystone: remove keystone_smp_ops code if psci is supported Message-ID: <20150701141211.GK7557@n2100.arm.linux.org.uk> References: <1435752784-30639-1-git-send-email-vitalya@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435752784-30639-1-git-send-email-vitalya@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1166 Lines: 33 On Wed, Jul 01, 2015 at 08:13:03AM -0400, Vitaly Andrianov wrote: > If we enable psci support we don't need keystone_smp_ops anymore. > > Signed-off-by: Vitaly Andrianov However, this is not necessary. If you look at arch/arm/kernel/setup.c, it contains this: psci_init(); #ifdef CONFIG_SMP if (is_smp()) { if (!mdesc->smp_init || !mdesc->smp_init()) { if (psci_smp_available()) smp_set_ops(&psci_smp_ops); else if (mdesc->smp) smp_set_ops(mdesc->smp); } smp_init_cpus(); smp_build_mpidr_hash(); } #endif So, the platforms' SMP ops won't be used even if they're provided when PSCI is available. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/