Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754364AbbGAOSw (ORCPT ); Wed, 1 Jul 2015 10:18:52 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35152 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754006AbbGAOSq (ORCPT ); Wed, 1 Jul 2015 10:18:46 -0400 MIME-Version: 1.0 In-Reply-To: <5593EF44.3050708@zoho.com> References: <5593EA18.8060109@zoho.com> <5593EF44.3050708@zoho.com> Date: Wed, 1 Jul 2015 16:18:45 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] Staging: android: ion: fix coding style From: Frans Klaver To: Sohny Thomas Cc: Greg KH , arve@android.com, riandrews@android.com, Sumit Semwal , carlos@cgarcia.org, kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2375 Lines: 58 On Wed, Jul 1, 2015 at 3:46 PM, Sohny Thomas wrote: > > - Fixed 80 char limit exceeding line > and a newline after declarations as per checkpatch.pl > > Signed-of-by: Sohny Thomas You can remove the dash, and fix the -off- typo (hint: use 'git commit -s' for automating it). Maybe hint towards what coding style is fixed in the summary: staging: android: ion: fix line over 80 characters > --- > drivers/staging/android/ion/ion.c | 1 + > drivers/staging/android/ion/ion_chunk_heap.c | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 6f48112..e44f5e6 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client, > struct ion_buffer *buffer; > struct dma_buf *dmabuf; > bool valid_handle; > + > DEFINE_DMA_BUF_EXPORT_INFO(exp_info); > > mutex_lock(&client->lock); > diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c > index 5474615..0813163 100644 > --- a/drivers/staging/android/ion/ion_chunk_heap.c > +++ b/drivers/staging/android/ion/ion_chunk_heap.c > @@ -173,8 +173,8 @@ struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data) > chunk_heap->heap.ops = &chunk_heap_ops; > chunk_heap->heap.type = ION_HEAP_TYPE_CHUNK; > chunk_heap->heap.flags = ION_HEAP_FLAG_DEFER_FREE; > - pr_debug("%s: base %lu size %zu align %ld\n", __func__, chunk_heap->base, > - heap_data->size, heap_data->align); > + pr_debug("%s: base %lu size %zu align %ld\n", __func__, > + chunk_heap->base, heap_data->size, heap_data->align); > > return &chunk_heap->heap; > > -- > > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/