Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754424AbbGAOVu (ORCPT ); Wed, 1 Jul 2015 10:21:50 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:36248 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753445AbbGAOVm (ORCPT ); Wed, 1 Jul 2015 10:21:42 -0400 MIME-Version: 1.0 In-Reply-To: <5593EF8E.9020002@zoho.com> References: <5593EDBF.6010008@zoho.com> <5593EF8E.9020002@zoho.com> Date: Wed, 1 Jul 2015 16:21:41 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef issue From: Frans Klaver To: Sohny Thomas Cc: Greg KH , arve@android.com, riandrews@android.com, Sumit Semwal , carlos@cgarcia.org, "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2060 Lines: 76 Subject suggestion: "staging: android: uapi: remove unnecessary typedef" That makes it immediately clear what the issue is. On Wed, Jul 1, 2015 at 3:47 PM, Sohny Thomas wrote: > > As per checkpatch.pl remove unnecessary typedef > Here ion_user_handle_t was used only in the header . > > Signed-of-by: Sohny Thomas Typo here as well. > --- > drivers/staging/android/uapi/ion.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h > index 68a14b4..9897403 100644 > --- a/drivers/staging/android/uapi/ion.h > +++ b/drivers/staging/android/uapi/ion.h > @@ -20,7 +20,6 @@ > #include > #include > > -typedef int ion_user_handle_t; > I would expect an extra line to be removed here. This will leave two empty lines. > /** > * enum ion_heap_types - list of all possible types of heaps > @@ -88,7 +87,7 @@ struct ion_allocation_data { > size_t align; > unsigned int heap_id_mask; > unsigned int flags; > - ion_user_handle_t handle; > + int handle; > }; > > /** > @@ -102,7 +101,7 @@ struct ion_allocation_data { > * provides the file descriptor and the kernel returns the handle. > */ > struct ion_fd_data { > - ion_user_handle_t handle; > + int handle; > int fd; > }; > > @@ -111,7 +110,7 @@ struct ion_fd_data { > * @handle: a handle > */ > struct ion_handle_data { > - ion_user_handle_t handle; > + int handle; > }; > > /** > -- > > > > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/