Message-ID: <1435763285.12101.100.camel@perches.com>
Subject: Re: [PATCH v2 3/3] Staging: android: uapi: Fix coding style typedef
 issue
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sohny Thomas <sohnythomas@zoho.com>, gregkh@linuxfoundation.org,
        arve@android.com, riandrews@android.com, sumit.semwal@linaro.org,
        carlos@cgarcia.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Date: Wed, 01 Jul 2015 08:08:05 -0700
In-Reply-To: <20150701143132.GZ28762@mwanda>
References: <5593EDBF.6010008@zoho.com> <5593EF8E.9020002@zoho.com>
	 <20150701143132.GZ28762@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 875
Lines: 28

On Wed, 2015-07-01 at 17:31 +0300, Dan Carpenter wrote:
> On Wed, Jul 01, 2015 at 07:17:58PM +0530, Sohny Thomas wrote:
> > 
> > As per checkpatch.pl remove unnecessary typedef
> > Here ion_user_handle_t was used only in the header .
> > 
> > Signed-of-by: Sohny Thomas <sohnythomas@zoho.com>
> 
> The original code was correct.

because the typedef is exposed to user-space. (uapi)

> Checkpatch.pl is not the king of the
> world, which you must obey or die.

As Dan once said, "it's less sentient than a squirrel".

> It is just a perl script.

Don't be a squirrel.
Please engage your brain when using the stupid little tool.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/