Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753339AbbGAVEU (ORCPT ); Wed, 1 Jul 2015 17:04:20 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:45552 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752321AbbGAVEK (ORCPT ); Wed, 1 Jul 2015 17:04:10 -0400 Message-ID: <559455C7.3030002@roeck-us.net> Date: Wed, 01 Jul 2015 14:04:07 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Peter Hung , jdelvare@suse.de CC: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung Subject: Re: [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting References: <1435627870-12249-1-git-send-email-hpeter+linux_kernel@gmail.com> <1435627870-12249-3-git-send-email-hpeter+linux_kernel@gmail.com> In-Reply-To: <1435627870-12249-3-git-send-email-hpeter+linux_kernel@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 39 Hi Peter, On 06/29/2015 06:31 PM, Peter Hung wrote: > The temperature value of Fintek F81866 is the same with > f71882fg. It located with 0x6c + 2*(nr), others located > with 0x6c + 2*(nr+1). We change the rule in f71882fg_probe(), > If type = f71858fg/f8000/f81866a. the temp_start will set to 0, > others are 1. > > The F81866 over-temperature beep setting is not the same with > f71882fg too. They are using the same address 63H, but F81866 is > using bit 0/1/2 & 4/5/6, others are using bit 1/2/3 & 5/6/7, > So we copy from fxxxx_temp_beep_attr[] to f81866_temp_beep_attr > and change bit setting. > > Signed-off-by: Peter Hung > --- [ .. ] > + if (data->type == f81866a) { > + size = ARRAY_SIZE(f81866_temp_beep_attr[0]); > + err = f71882fg_create_sysfs_files(pdev, > + &f81866_temp_beep_attr[0][0], > + size * nr_temps); > + > + } else { > + size = ARRAY_SIZE(fxxxx_temp_beep_attr[0]; TskTsk ... turns out you didn't even compile test this code. How am I supposed to know that it is working ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/