Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753580AbbGAWGR (ORCPT ); Wed, 1 Jul 2015 18:06:17 -0400 Received: from mail-ig0-f170.google.com ([209.85.213.170]:34767 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbbGAWGK (ORCPT ); Wed, 1 Jul 2015 18:06:10 -0400 Date: Wed, 1 Jul 2015 15:06:05 -0700 From: Dmitry Torokhov To: Jason Gunthorpe Cc: Peter Huewe , Jarkko Sakkinen , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: Fix initialization of the cdev Message-ID: <20150701220605.GD36579@dtor-ws> References: <20150630191531.GA29764@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150630191531.GA29764@obsidianresearch.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1869 Lines: 52 On Tue, Jun 30, 2015 at 01:15:31PM -0600, Jason Gunthorpe wrote: > When a cdev is contained in a dynamic structure the cdev parent kobj > should be set to the kobj that controls the lifetime of the enclosing > structure. In TPM's case this is the embedded struct device. > > Also, cdev_init 0's the whole structure, so all sets must be after, > not before. This fixes module ref counting and cdev. > > Fixes: 313d21eeab92 ("tpm: device class for tpm") > Signed-off-by: Jason Gunthorpe Right, when embedding cdev its lifetime should be tied to the lifetime of the enclosing structure. Reviewed-by: Dmitry Torokhov > --- > drivers/char/tpm/tpm-chip.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Peter, I've only compile tests this. Thanks > > diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c > index 283f00a7f036..1082d4bb016a 100644 > --- a/drivers/char/tpm/tpm-chip.c > +++ b/drivers/char/tpm/tpm-chip.c > @@ -129,8 +129,9 @@ struct tpm_chip *tpmm_chip_alloc(struct device *dev, > > device_initialize(&chip->dev); > > - chip->cdev.owner = chip->pdev->driver->owner; > cdev_init(&chip->cdev, &tpm_fops); > + chip->cdev.owner = chip->pdev->driver->owner; > + chip->cdev.kobj.parent = &chip->dev.kobj; > > return chip; > } > -- > 2.1.4 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/