Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbbGAXUE (ORCPT ); Wed, 1 Jul 2015 19:20:04 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:53487 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753020AbbGAXT7 (ORCPT ); Wed, 1 Jul 2015 19:19:59 -0400 From: "Rafael J. Wysocki" To: Tomeu Vizoso Cc: linux-kernel@vger.kernel.org, Mark Brown , Greg Kroah-Hartman Subject: Re: [PATCH v1 10/10] core: platform: use fwnode_driver_match_device() Date: Thu, 02 Jul 2015 01:46:19 +0200 Message-ID: <4797404.Tr5H8KsQkK@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1435676108-20590-11-git-send-email-tomeu.vizoso@collabora.com> References: <1435676108-20590-1-git-send-email-tomeu.vizoso@collabora.com> <1435676108-20590-11-git-send-email-tomeu.vizoso@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1591 Lines: 48 On Tuesday, June 30, 2015 04:55:08 PM Tomeu Vizoso wrote: > Instead of calling both of_driver_match_device() and > acpi_driver_match_device(), call fwnode_driver_match_device() which > should be able to sort out what firmware describes the device in > question. > > Signed-off-by: Tomeu Vizoso This one should be part of the other set IMO. Or please just combine the two sets so it is more clear what the new helpers are intended for. > --- > > drivers/base/platform.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 063f0ab..a7e7757 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -843,12 +843,8 @@ static int platform_match(struct device *dev, struct device_driver *drv) > if (pdev->driver_override) > return !strcmp(pdev->driver_override, drv->name); > > - /* Attempt an OF style match first */ > - if (of_driver_match_device(dev, drv)) > - return 1; > - > - /* Then try ACPI style match */ > - if (acpi_driver_match_device(dev, drv)) > + /* Attempt a firmware match first */ > + if (fwnode_driver_match_device(dev, drv)) > return 1; > > /* Then try to match against the id table */ > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/