Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754445AbbGBCDZ (ORCPT ); Wed, 1 Jul 2015 22:03:25 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:54854 "EHLO smtprelay.synopsys.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754057AbbGBCDQ convert rfc822-to-8bit (ORCPT ); Wed, 1 Jul 2015 22:03:16 -0400 From: John Youn To: "balbi@ti.com" , John Youn CC: Subbaraya Sundeep Bhatta , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Subbaraya Sundeep Bhatta Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Thread-Topic: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Thread-Index: AQHQk7GIA+Sqgb4cD02xex3whosYqw== Date: Thu, 2 Jul 2015 02:03:14 +0000 Message-ID: <2B3535C5ECE8B5419E3ECBE3007729090175264F3B@US01WEMBX2.internal.synopsys.com> References: <1432203408-5482-1-git-send-email-sbhatta@xilinx.com> <1432203408-5482-3-git-send-email-sbhatta@xilinx.com> <20150629214701.GK1019@saruman.tx.rr.com> <20150629214854.GL1019@saruman.tx.rr.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.9.139.37] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1905 Lines: 56 On 6/29/2015 2:48 PM, Felipe Balbi wrote: > Hi again, > > On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote: >> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote: >>> We need to return error to caller if command is not sent to >>> controller succesfully. >>> >>> Signed-off-by: Subbaraya Sundeep Bhatta >>> Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver) >>> Cc: >>> --- >>> v2 changes: >>> Added Fixes and Cc in commit message. >> >> I noticed that this breaks at least my AM437x silicon with DWC3 2.40a >> when used with g_zero and testusb. As of now, it could be that silicon >> is mis-behaving because I got a Transfer Complete before the failing Set >> Endpoint Transfer Resource command. >> >> In any case, can you run on your setup with g_zero and test.sh/testusb >> [1]/[2] just to verify that it really works for you ? >> >> Meanwhile, I'll continue testing on my end. >> >> cheers >> >> [1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:testusb.c >> [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:test.sh > > Adding John here. John, any chance you could fire up dwc3 on HAPS and > see wether it works or fails for you ? > > cheers > Hi Felipe, Just an update on this. I'm trying to get this working with our latest IP with dwc3 from your testing/next branch. It fails the usbtest with a problem unrelated to this patch. It passes on 4.1.1. I'll have to look into the failure but I won't get to it until next week as I'm off the rest of this week. Regards, John -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/