Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754284AbbGBCxl (ORCPT ); Wed, 1 Jul 2015 22:53:41 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:55577 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753396AbbGBCxe (ORCPT ); Wed, 1 Jul 2015 22:53:34 -0400 X-Listener-Flag: 11101 Message-ID: <1435805534.3526.23.camel@mtksdaap41> Subject: Re: [PATCH v2 2/4] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers From: James Liao To: Daniel Kurtz CC: "open list:OPEN FIRMWARE AND..." , "Mike Turquette" , srv_heupstream , Stephen Boyd , "linux-kernel@vger.kernel.org" , Ricky Liang , Rob Herring , , Sascha Hauer , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" Date: Thu, 2 Jul 2015 10:52:14 +0800 In-Reply-To: References: <1435633127-31952-1-git-send-email-jamesjj.liao@mediatek.com> <1435633127-31952-3-git-send-email-jamesjj.liao@mediatek.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1115 Lines: 37 Hi Daniel, > > +Required Properties: > > + > > +- compatible: Should be: > > + - "mediatek,mt8173-imgsys", "syscon" > > +- #clock-cells: Must be 1 > > + > > +The imgsys controller uses the common clk binding from > > +Documentation/devicetree/bindings/clock/clock-bindings.txt > > +The available clocks are defined in dt-bindings/clock/mt*-clk.h. > > + > > +Example: > > + > > +imgsys: imgsys@15000000 { > > Since these nodes will be supplying clocks to the rest of the system, > I think the "name" part of each of these should all be > "clock-controller", like topckgen and apmixedsys: > > imgsys: clock-controller@15000000 { These subsystems (and topckgen also) also contains other functions such as reset controller, which may be implemented in clk/mediatek/ in the future. It is suitable to use "clock-controller" as their name? Best regards, James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/