Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752268AbbGBDAV (ORCPT ); Wed, 1 Jul 2015 23:00:21 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:60034 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbbGBDAN (ORCPT ); Wed, 1 Jul 2015 23:00:13 -0400 Date: Wed, 1 Jul 2015 22:00:09 -0500 From: Felipe Balbi To: John Youn CC: "balbi@ti.com" , Subbaraya Sundeep Bhatta , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Subbaraya Sundeep Bhatta Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Message-ID: <20150702030009.GB29462@saruman.tx.rr.com> Reply-To: References: <1432203408-5482-1-git-send-email-sbhatta@xilinx.com> <1432203408-5482-3-git-send-email-sbhatta@xilinx.com> <20150629214701.GK1019@saruman.tx.rr.com> <20150629214854.GL1019@saruman.tx.rr.com> <2B3535C5ECE8B5419E3ECBE3007729090175264F3B@US01WEMBX2.internal.synopsys.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8P1HSweYDcXXzwPJ" Content-Disposition: inline In-Reply-To: <2B3535C5ECE8B5419E3ECBE3007729090175264F3B@US01WEMBX2.internal.synopsys.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3322 Lines: 95 --8P1HSweYDcXXzwPJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2015 at 02:03:14AM +0000, John Youn wrote: > On 6/29/2015 2:48 PM, Felipe Balbi wrote: > > Hi again, > >=20 > > On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote: > >> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wro= te: > >>> We need to return error to caller if command is not sent to > >>> controller succesfully. > >>> > >>> Signed-off-by: Subbaraya Sundeep Bhatta > >>> Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver) > >>> Cc: > >>> --- > >>> v2 changes: > >>> Added Fixes and Cc in commit message. > >> > >> I noticed that this breaks at least my AM437x silicon with DWC3 2.40a > >> when used with g_zero and testusb. As of now, it could be that silicon > >> is mis-behaving because I got a Transfer Complete before the failing S= et > >> Endpoint Transfer Resource command. > >> > >> In any case, can you run on your setup with g_zero and test.sh/testusb > >> [1]/[2] just to verify that it really works for you ? > >> > >> Meanwhile, I'll continue testing on my end. > >> > >> cheers > >> > >> [1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c= 81374aafb795c6e40:testusb.c > >> [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c= 81374aafb795c6e40:test.sh > >=20 > > Adding John here. John, any chance you could fire up dwc3 on HAPS and > > see wether it works or fails for you ? > >=20 > > cheers > >=20 >=20 > Hi Felipe, >=20 > Just an update on this. >=20 > I'm trying to get this working with our latest IP with dwc3 from your > testing/next branch. It fails the usbtest with a problem unrelated to > this patch. >=20 > It passes on 4.1.1. >=20 > I'll have to look into the failure but I won't get to it until next > week as I'm off the rest of this week. interesting... If you could post failure signature, I can help looking at it, but I guess it's too late to ask :-) thanks for helping though --=20 balbi --8P1HSweYDcXXzwPJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVlKk5AAoJEIaOsuA1yqRE7EgP/3djuB8jRqmjW04WTqHS3QqY 4NUF7Q16L/cDUz1H/cHODACsXw3iOFOKLyOPa1wodhxvn2Qw3A+IaV9wDooXbPL2 ZdEC9uX3/caMoV4H6UiTnN8q8FjUFCSM5xGQhnjyTus/fUdv7dIv/dH2wqFz2AHp 6NeTbbGQKFacDMgGBlzh16ryD4YHwUPZJy9tnXFHof9Xo9QhA9Gu9NbGn995NfXa W/NEf40xbz9ednQi5kYr9Njc7B2AJFdKEB0CzfyPDWi7DC+sHkTdljy4UYoP0dOC Jc19y9Q3S36ChwZKD6vsCAXGN0TY7SU/XBFwSBwA8P4y/YciplQWLv8dszmaAsGw 1A4x/j1UCdKora6RDe3bGfP4/+Vdv6zLJBF0YBLjUvhjn7RTMFh5Fff6a4HlRcuw rnD2CvduWZGnHpJWcPum9HhLjPbDZaJAQTCHKpkOxo88/dXamsFnw4jKfQ/hpb3l zRxIsFR1vrFDJSUVZ1j36ghDEThQDGh7dQVWkMPCPFnExllcpAIa2Nzh1n7WgXrk JF6CyeQ6oyaihIGdG/MygFaoisviC9Amdv9CH75JzdBf6yUgpExn5Zq4LTtboCxl dlV4zRjJ7Gn+IBQL2NlSxf/8x5kBrCIIIWF4NPvYGsx1HbMo5qE3wQxuZtWt+q8b 2rokfzZUocmMAkrQx7Qr =WQWT -----END PGP SIGNATURE----- --8P1HSweYDcXXzwPJ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/