Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753131AbbGBDIq (ORCPT ); Wed, 1 Jul 2015 23:08:46 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:35098 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbbGBDIp (ORCPT ); Wed, 1 Jul 2015 23:08:45 -0400 Subject: Re: [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting To: Guenter Roeck , jdelvare@suse.de References: <1435627870-12249-1-git-send-email-hpeter+linux_kernel@gmail.com> <1435627870-12249-3-git-send-email-hpeter+linux_kernel@gmail.com> <559455C7.3030002@roeck-us.net> Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw, Peter Hung From: Peter Hung Message-ID: <5594AB3B.90301@gmail.com> Date: Thu, 2 Jul 2015 11:08:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <559455C7.3030002@roeck-us.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 23 Hi Guenter, Guenter Roeck 於 2015/7/2 上午 05:04 寫道: > Hi Peter, >> + } else { >> + size = ARRAY_SIZE(fxxxx_temp_beep_attr[0]; > > TskTsk ... turns out you didn't even compile test this code. > How am I supposed to know that it is working ? Sorry, It's my fault. I should re-testing patch after fix checkpatch.sh warnings. I'll re-confirm all patches again before send it to maintainer. -- With Best Regards, Peter Hung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/