Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbbGBGQs (ORCPT ); Thu, 2 Jul 2015 02:16:48 -0400 Received: from mail.siteground.com ([67.19.240.234]:56376 "EHLO mail.siteground.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbbGBGQi (ORCPT ); Thu, 2 Jul 2015 02:16:38 -0400 Message-ID: <5594D742.6040202@kyup.com> Date: Thu, 02 Jul 2015 09:16:34 +0300 From: Nikolay Borisov Organization: Kyup Ltd. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Theodore Ts'o" , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ext4: make use of sb_getblk_gfp References: <1435645609-20387-1-git-send-email-kernel@kyup.com> <1435645609-20387-2-git-send-email-kernel@kyup.com> <20150702061427.GB3108@thunk.org> In-Reply-To: <20150702061427.GB3108@thunk.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - mail.siteground.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - kyup.com X-Get-Message-Sender-Via: mail.siteground.com: none X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 24 On 07/02/2015 09:14 AM, Theodore Ts'o wrote: > On Tue, Jun 30, 2015 at 09:26:49AM +0300, Nikolay Borisov wrote: >> Switch ext4 to using sb_getblk_gfp with GFP_NOFS added, this fixes >> possible deadlocks in the page writeback path. >> >> Signed-off-by: Nikolay Borisov > > I've added this to the ext4.git tree, thanks. > > - Ted Thanks! Just a question that popped to my mind after discussing with a colleague - Is GFP_NOFS enough here or should it be GFP_NOIO? Presumably the latter is a stronger guarantee that we are not going to hit any fs/writeback related code? Nikolay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/