Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbbGBHDw (ORCPT ); Thu, 2 Jul 2015 03:03:52 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:35244 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbbGBHDp (ORCPT ); Thu, 2 Jul 2015 03:03:45 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: heiko@sntech.de X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <33b89e1ec360d359609211342885cd43> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5594E246.6090500@rock-chips.com> Date: Thu, 02 Jul 2015 15:03:34 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= CC: dri-devel@lists.freedesktop.org, David Airlie , Daniel Kurtz , Philipp Zabel , Daniel Vetter , Rob Clark , tfiga@chromium.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, sandy.huang@rock-chips.com, dkm@rock-chips.com, zwl@rock-chips.com, xw@rock-chips.com Subject: Re: [PATCH] drm/rockchip: vop: remove hardware cursor window References: <1435744173-23112-1-git-send-email-mark.yao@rock-chips.com> <1617606.rtBNOYcypX@diego> In-Reply-To: <1617606.rtBNOYcypX@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1718 Lines: 51 On 2015年07月01日 19:52, Heiko Stübner wrote: > Hi Mark, > > Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao: >> hardware cursor windows only have some fixed size, and not support >> width virtual, when move hardware cursor windows outside of left, >> the display would be wrong, so this window can't for cursor now. >> >> And Tag hardware cursor window as a overlay is wrong, will make >> userspace wrong behaviour. >> >> So just remove the hardware cursor window >> >> Signed-off-by: Mark Yao >> --- >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >> @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = >> { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { >> .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base >> = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = >> 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; >> >> static const struct vop_data rk3288_vop = { > you should probably also remove the > > static const struct vop_win_phy cursor_data > > completely then, as it is now unused? > > > Heiko > > > OK -- Ｍark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/