Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751141AbbGBHKr (ORCPT ); Thu, 2 Jul 2015 03:10:47 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:32876 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbbGBHKk convert rfc822-to-8bit (ORCPT ); Thu, 2 Jul 2015 03:10:40 -0400 MIME-Version: 1.0 In-Reply-To: <20150701114849.GE17577@pali> References: <1435114671-24380-1-git-send-email-alex.hung@canonical.com> <20150626145621.GU2890@pali> <20150629122953.GF16230@pali> <20150630085814.GE27720@pali> <20150701114849.GE17577@pali> Date: Thu, 2 Jul 2015 15:10:39 +0800 Message-ID: Subject: Re: [PATCH][v2] asus-rbtn: new driver for asus radio button for Windows 8 From: Alex Hung To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Darren Hart , Corentin Chary , "platform-driver-x86@vger.kernel.org" , acpi4asus-user@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 37 Thanks for the support. I will create v3 based with LED triggers. Just for information. ASUS's wording is as below: Fn+F2 can be used to turn on or off all radio capabilities in the device (as known as airplane mode switch). I don't have any preferences on the name. We may use the term airplane-mode do if asus-rbtn is not preferred. Let me know if there are any suggestions. On Wed, Jul 1, 2015 at 7:48 PM, Pali Rohár wrote: > On Wednesday 01 July 2015 00:09:41 Alex Hung wrote: >> ATK4001 is an independent ACPI device, and Method(HSWC) is its method >> to control LED (actually it has other functions but only LED is needed >> so far). > > If this driver is for supporting ACPI ATK4001 device (which has couple > of methods, not only LED) it is really good idea to name it asus-rbtn? > > Darren, you as maintainer of platform drivers, what do you think? I > believe in future this driver will be extended to support more functions > and so name asus-rbtn will be confusing. > > -- > Pali Rohár > pali.rohar@gmail.com -- Cheers, Alex Hung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/