Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752670AbbGBH0b (ORCPT ); Thu, 2 Jul 2015 03:26:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60553 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbbGBH0Y (ORCPT ); Thu, 2 Jul 2015 03:26:24 -0400 Date: Thu, 2 Jul 2015 09:26:21 +0200 From: Michal Hocko To: Nicholas Krause Cc: akpm@linux-foundation.org, mgorman@suse.de, n-horiguchi@ah.jp.nec.com, sasha.levin@oracle.com, Yalin.Wang@sonymobile.com, jmarchan@redhat.com, kirill@shutemov.name, rientjes@google.com, vbabka@suse.cz, aneesh.kumar@linux.vnet.ibm.com, ebru.akagunduz@gmail.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm:Make the function zap_huge_pmd bool Message-ID: <20150702072621.GB12547@dhcp22.suse.cz> References: <1435775277-27381-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435775277-27381-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2113 Lines: 66 On Wed 01-07-15 14:27:57, Nicholas Krause wrote: > This makes the function zap_huge_pmd have a return type of bool > now due to this particular function always returning one or zero > as its return value. How does this help anything? IMO this just generates a pointless churn in the code without a good reason. > Signed-off-by: Nicholas Krause > --- > include/linux/huge_mm.h | 2 +- > mm/huge_memory.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index f10b20f..e83174e 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -19,7 +19,7 @@ extern struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, > unsigned long addr, > pmd_t *pmd, > unsigned int flags); > -extern int zap_huge_pmd(struct mmu_gather *tlb, > +extern bool zap_huge_pmd(struct mmu_gather *tlb, > struct vm_area_struct *vma, > pmd_t *pmd, unsigned long addr); > extern int mincore_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index c107094..32b1993 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1384,11 +1384,11 @@ out: > return 0; > } > > -int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > +bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > pmd_t *pmd, unsigned long addr) > { > spinlock_t *ptl; > - int ret = 0; > + int ret = false; > > if (__pmd_trans_huge_lock(pmd, vma, &ptl) == 1) { > struct page *page; > @@ -1419,7 +1419,7 @@ int zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > tlb_remove_page(tlb, page); > } > pte_free(tlb->mm, pgtable); > - ret = 1; > + ret = true; > } > return ret; > } > -- > 2.1.4 > -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/