Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbbGBHuN (ORCPT ); Thu, 2 Jul 2015 03:50:13 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:33134 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475AbbGBHuH (ORCPT ); Thu, 2 Jul 2015 03:50:07 -0400 MIME-Version: 1.0 In-Reply-To: <20150702041046.GG17109@ZenIV.linux.org.uk> References: <20150621211213.GA18732@ZenIV.linux.org.uk> <5587F943.3040006@samsung.com> <20150701062752.GC17109@ZenIV.linux.org.uk> <55939BE3.6040902@samsung.com> <20150701082753.GD17109@ZenIV.linux.org.uk> <5593A7A0.6050400@samsung.com> <20150701085507.GE17109@ZenIV.linux.org.uk> <5593CE37.4070307@samsung.com> <20150701184408.GF17109@ZenIV.linux.org.uk> <20150702032042.GA32613@ZenIV.linux.org.uk> <20150702041046.GG17109@ZenIV.linux.org.uk> Date: Thu, 2 Jul 2015 10:50:05 +0300 Message-ID: Subject: Re: running out of tags in 9P (was Re: [git pull] vfs part 2) From: Andrey Ryabinin To: Al Viro Cc: Andrey Ryabinin , Linus Torvalds , LKML , linux-fsdevel , "Aneesh Kumar K.V" , Eric Van Hensbergen , linux-nfs@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1152 Lines: 26 [repeating, since my previous email didn't reach mailing lists] 2015-07-02 7:10 GMT+03:00 Al Viro : >> It should be easy to confirm - in p9_client_prepare_req() add >> if (WARN_ON_ONCE(tag != (u16)tag)) { >> p9_idpool_put(tag, c->tagpool); >> return ERR_PTR(-ENOMEM); >> } >> right after >> tag = p9_idpool_get(c->tagpool); >> if (tag < 0) >> return ERR_PTR(-ENOMEM); >> >> and see if it triggers. I'm not sure if failing with ENOMEM is the >> right response (another variant is to sleep there until the pile >> gets cleaned or until we get killed), and WARN_ON_ONCE() is definitely >> not for the real work, but it will do for confirming that this is what >> we are hitting. > Apparently, I'm seeing something else. That WARN_ON_ONCE didn't trigger. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/