Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753814AbbGBItr (ORCPT ); Thu, 2 Jul 2015 04:49:47 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:34718 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752185AbbGBIt2 (ORCPT ); Thu, 2 Jul 2015 04:49:28 -0400 MIME-Version: 1.0 In-Reply-To: <1435754753-31307-2-git-send-email-tomeu.vizoso@collabora.com> References: <1435754753-31307-1-git-send-email-tomeu.vizoso@collabora.com> <1435754753-31307-2-git-send-email-tomeu.vizoso@collabora.com> Date: Thu, 2 Jul 2015 10:49:27 +0200 X-Google-Sender-Auth: g3yKOVi9sEXEIXPIrEeVUaYIqQc Message-ID: Subject: Re: [PATCH v1 1/3] gpio: defer probe if pinctrl cannot be found From: Geert Uytterhoeven To: Tomeu Vizoso Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , linux-tegra@vger.kernel.org, Linus Walleij , Grant Likely , Rob Herring , Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1537 Lines: 39 Hi Tomeu, On Wed, Jul 1, 2015 at 2:45 PM, Tomeu Vizoso wrote: > When an OF node has a pin range for its GPIOs, return -EPROBE_DEFER if > the pin controller isn't available. > > Otherwise, the GPIO range wouldn't be set at all unless the pin > controller probed always before the GPIO chip. > > With this change, the probe of the GPIO chip will be deferred and will > be retried at a later point, hopefully once the pin controller has been > registered and probed already. > > Signed-off-by: Tomeu Vizoso I was a bit afraid this would break the case of gpio controllers that are also pin controllers, i.e. where "gpio-ranges" points to the gpio controller itself[*], but it doesn't. Tested-by: Geert Uytterhoeven [*] E.g. "[PATCH 2/7] ARM: shmobile: r8a7740 dtsi: Add missing "gpio-ranges" to gpio node" (http://www.spinics.net/lists/linux-sh/msg43077.html) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/