Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbbGBK16 (ORCPT ); Thu, 2 Jul 2015 06:27:58 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:37363 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753047AbbGBK1u (ORCPT ); Thu, 2 Jul 2015 06:27:50 -0400 X-Sasl-enc: FGxDf5ESQ5BLNduiXgPUU4NR8DL+W1mlFGbULvRP7nXy 1435832869 Date: Thu, 2 Jul 2015 13:27:48 +0300 From: Sergei Zviagintsev To: David Herrmann Cc: Greg Kroah-Hartman , Daniel Mack , David Herrmann , Djalal Harouni , linux-kernel Subject: Re: [PATCH RFC 4/5] kdbus: handle WARN_ON cases properly when decrementing quota Message-ID: <20150702102748.GR17917@localhost.localdomain> References: <1435497454-10464-1-git-send-email-sergei@s15v.net> <1435497454-10464-5-git-send-email-sergei@s15v.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 20 Hi, On Thu, Jul 02, 2015 at 10:37:05AM +0200, David Herrmann wrote: > Hi > > On Sun, Jun 28, 2015 at 3:17 PM, Sergei Zviagintsev wrote: > > If we spotted inconsistency, fix it by setting values to zero. > > Why? > > I prefer doing nothing and just bailing out on programming errors. > Setting it to 0 just complicates debugging and drops possibly useful > information ('what was the counter value at that time?'). Thank you for commenting on this! Now it seems to be clear for me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/