Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbbGBLPP (ORCPT ); Thu, 2 Jul 2015 07:15:15 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36113 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753164AbbGBLPF (ORCPT ); Thu, 2 Jul 2015 07:15:05 -0400 Date: Thu, 2 Jul 2015 12:14:56 +0100 From: Mark Brown To: Charles Keepax Cc: Maninder Singh , lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, pankaj.m@samsung.com Message-ID: <20150702111456.GY11162@sirena.org.uk> References: <1435823829-3174-1-git-send-email-maninder1.s@samsung.com> <20150702101849.GB16517@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Zzd9Wh/bp6DhMAqJ" Content-Disposition: inline In-Reply-To: <20150702101849.GB16517@opensource.wolfsonmicro.com> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2] regulator: wm831x-dcdc: Use pointer after NULL check X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1454 Lines: 39 --Zzd9Wh/bp6DhMAqJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2015 at 11:18:49AM +0100, Charles Keepax wrote: > On Thu, Jul 02, 2015 at 01:27:09PM +0530, Maninder Singh wrote: > > pdata is used before NULL check, so it looks misleading. > The patch basically looks fine, but it feels a bit like needless > churn. The current code is perfectly correct and feels clear > enough to me. It's a bug - either the validation shouldn't be there or it needs to be before the use otherwise it does nothing.=20 --Zzd9Wh/bp6DhMAqJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVlR0vAAoJECTWi3JdVIfQRFEH/RkchFt1jFXOSq95/9ez4ATF K5FUDM8xvjLJUUqnKA7wrxYk2zKA+vpnQZVEcHMZyrIkaA7euYld5hHcUhK9p7MZ /cXKGQfa6fUT5mXmHkYd2mIRz9+6Vj/Rgz61MoKvU6SC/W7kE4YRDatmmyEn5gXC H5w9v6Q99tHT1hiiGF4IPl3TX+e77JdORE2yekieHaelvceimI7GC/jO+hQRJ4cQ R3Nxj8UTu9eGxmDR17wgEcDhel8WmAUSZRTXrWr6sIbrETZvouUGTIrTklzAtU/m ZL8SfPqJ8dSorzNETzPD7mmJFW/8SWqIrzBrugYsQxi/S0JMqMYCRM9bQjHeKOw= =2ell -----END PGP SIGNATURE----- --Zzd9Wh/bp6DhMAqJ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/