Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbbGBLeF (ORCPT ); Thu, 2 Jul 2015 07:34:05 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36131 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbbGBLd7 (ORCPT ); Thu, 2 Jul 2015 07:33:59 -0400 Date: Thu, 2 Jul 2015 12:33:50 +0100 From: Mark Brown To: Charles Keepax Cc: Maninder Singh , lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, pankaj.m@samsung.com Message-ID: <20150702113350.GZ11162@sirena.org.uk> References: <1435823829-3174-1-git-send-email-maninder1.s@samsung.com> <20150702101849.GB16517@opensource.wolfsonmicro.com> <20150702111456.GY11162@sirena.org.uk> <20150702111950.GD16517@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c1qHkdEbEbCG94PZ" Content-Disposition: inline In-Reply-To: <20150702111950.GD16517@opensource.wolfsonmicro.com> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2] regulator: wm831x-dcdc: Use pointer after NULL check X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1569 Lines: 42 --c1qHkdEbEbCG94PZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2015 at 12:19:50PM +0100, Charles Keepax wrote: > On Thu, Jul 02, 2015 at 12:14:56PM +0100, Mark Brown wrote: > > It's a bug - either the validation shouldn't be there or it needs to be > > before the use otherwise it does nothing.=20 > ARRAY_SIZE being implemented with sizeof's means that no actual > dereference takes place. But if we have multiple people thinking > this looks buggy then I guess the code probably isn't clear > enough at the moment. Ah, I see. I'd not actually looked at the patch yet only the changelog quoted in the discussion. --c1qHkdEbEbCG94PZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVlSGdAAoJECTWi3JdVIfQodQH/1O2HSSf7SYkaDB3XW1ZdlCo OtsHeedsBooCbcutqmIXTg7TCMrNNJVOcxCCiTbjMnBFPeddKtYHTnDkotd8GNLM oEFPdOlZoEfXQ/BrKTJpAsEbQdYkWZlTRNh0Dnz6slDOHD9tQgtxdyokRXaj9mGu e/VS+JwZHZ5gEIyHfwbzcj+BkLU0HURH9jEw2vWpluGYN1JLQo12JmUOuzwJRj25 q6n8v+q0SQ6elGUMhkYeDhDrEh2rpFnst7x/k6Vf3oWHuWL5UXqsHgdUXabh38ZQ BQDco4gJCcWKcUESHFLNZ+dlKMTLvwFCbtVFMXdE+WRXV5yz7Ch27Pcz5tBWQwk= =w7Bg -----END PGP SIGNATURE----- --c1qHkdEbEbCG94PZ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/