From: Phil Edworthy <phil.edworthy@renesas.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Felipe Balbi <balbi@ti.com>, Ulrich Hecht <ulrich.hecht@gmail.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>
Subject: RE: [PATCH v2] usb: renesas_usbhs: Allow an OTG PHY driver to provide
 VBUS
Thread-Topic: [PATCH v2] usb: renesas_usbhs: Allow an OTG PHY driver to
 provide VBUS
Thread-Index: AQHQtJov6QAOeJ5fNUapptyc9faHp53IB+4AgAAMNFA=
Date: Thu, 2 Jul 2015 12:01:13 +0000
Message-ID: <SIXPR06MB06390C94CB491B065194B4F4F5970@SIXPR06MB0639.apcprd06.prod.outlook.com>
References: <1435822602-22685-1-git-send-email-phil.edworthy@renesas.com>
 <55951D98.7050003@cogentembedded.com>
In-Reply-To: <55951D98.7050003@cogentembedded.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2015 12:01:13.6924
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SIXPR06MB0921
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1868
Lines: 68

Hi Sergei,

On 02 July 2015 12:17, Sergei wrote:
> To: Phil Edworthy; Yoshihiro Shimoda
> Hello.
> 
> On 7/2/2015 10:36 AM, Phil Edworthy wrote:
> 
> > These changes allow a PHY driver to trigger a VBUS interrupt and
> > to provide the value of VBUS.
> 
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> 
> [...]
> 
> > diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c
> b/drivers/usb/renesas_usbhs/mod_gadget.c
> > index dc2aa32..51b63f9 100644
> > --- a/drivers/usb/renesas_usbhs/mod_gadget.c
> > +++ b/drivers/usb/renesas_usbhs/mod_gadget.c
> [...]
> > @@ -947,12 +966,27 @@ static int usbhsg_set_selfpowered(struct usb_gadget
> *gadget, int is_self)
> >   	return 0;
> >   }
> >
> > +static int usbhsg_vbus_session(struct usb_gadget *gadget, int is_active)
> > +{
> > +	struct usbhsg_gpriv *gpriv = usbhsg_gadget_to_gpriv(gadget);
> > +	struct usbhs_priv *priv = usbhsg_gpriv_to_priv(gpriv);
> > +	struct platform_device *pdev = usbhs_priv_to_pdev(priv);
> > +
> > +	priv->vbus_is_indirect = 1;
> 
>     s/1/true/.
Ok.
 
> > +	priv->vbus_indirect_value = !!is_active;
> > +
> > +	renesas_usbhs_call_notify_hotplug(pdev);
> > +
> > +	return 0;
> > +}
> > +
> [...]
> > @@ -994,6 +1028,10 @@ int usbhs_mod_gadget_probe(struct usbhs_priv
> *priv)
> >   		goto usbhs_mod_gadget_probe_err_gpriv;
> >   	}
> >
> > +	gpriv->transceiver = usb_get_phy(USB_PHY_TYPE_UNDEFINED);
> > +	dev_info(dev, "%s transceiver found\n",
> > +		 gpriv->transceiver ? "" : "No");
> 
>     Hm, I told you to make this message cleaner, and you haven't. :-(
Ah, sorry, I missed that comment.

> [...]
> 
> WBR, Sergei

Thanks
Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/