Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbbGBMLM (ORCPT ); Thu, 2 Jul 2015 08:11:12 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:6835 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751035AbbGBMLF convert rfc822-to-8bit (ORCPT ); Thu, 2 Jul 2015 08:11:05 -0400 X-IronPort-AV: E=Sophos;i="5.15,392,1432566000"; d="scan'208";a="189595505" From: Phil Edworthy To: Sergei Shtylyov , Simon Horman CC: Magnus Damm , Kishon Vijay Abraham I , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Yoshihiro Shimoda" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-sh@vger.kernel.org" Subject: RE: [PATCH v2] arm: koelsch: make USB0 perform Host/Function switching Thread-Topic: [PATCH v2] arm: koelsch: make USB0 perform Host/Function switching Thread-Index: AQHQtJ99R37xFau970O+YjNqRAB7sZ3IDDmAgAAKoFA= Date: Thu, 2 Jul 2015 12:11:00 +0000 Message-ID: References: <1435824869-22784-1-git-send-email-phil.edworthy@renesas.com> <5595213B.7080809@cogentembedded.com> In-Reply-To: <5595213B.7080809@cogentembedded.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: cogentembedded.com; dkim=none (message not signed) header.d=none; x-originating-ip: [193.141.220.21] x-microsoft-exchange-diagnostics: 1;SIXPR06MB0922;5:ovxj25vL1HDknSQHkRA4o9i/mEE6tY8nhdyT0H9WVCYByzqnkQKKsZBftjUxul+1Q16SwIqNY/WoU+2ljSwWUE6hUX1FihwR+amIki+KXO2sXijif3shSNwuOj/2/dDKobNQImUbKFl9LxWy4Dwhzw==;24:G/IYmiB6owCmJ0IfyjEjYoUMNfQhJRrfJagGg8Sy4Ri8hzM0Svgk2ML3rat6esX2R6Wv3tZJlmVY/bTVi8FlGbMNgMy6IaKeZ+n2qH3EH1c=;20:zLsPH0AYlgT8aPfHgwPuP6oyUwTeYKvbVST6/e484MgDj1QUL91xeCru6HbtdwzZEFXsG2KiyYmajY2axm3/vnH+PDEnbbOMrczQqtcOIqJspFf60KaUJ+XzgbNvgAVd8hCUSKXdnl5s+jLsQzk7WxbJeziiwMxVuUtV9rMjmMo= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SIXPR06MB0922; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:SIXPR06MB0922;BCL:0;PCL:0;RULEID:;SRVR:SIXPR06MB0922; x-forefront-prvs: 06259BA5A2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(479174004)(24454002)(51704005)(377454003)(5001770100001)(74316001)(40100003)(5002640100001)(46102003)(189998001)(122556002)(66066001)(77156002)(62966003)(87936001)(86362001)(76176999)(2656002)(2950100001)(106116001)(54356999)(102836002)(50986999)(76576001)(5003600100002)(19580395003)(2900100001)(77096005)(92566002)(33656002)(5001960100002);DIR:OUT;SFP:1102;SCL:1;SRVR:SIXPR06MB0922;H:SIXPR06MB0639.apcprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2015 12:11:00.3680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SIXPR06MB0922 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 53 Hi Sergei. On 02 July 2015 12:32, Sergei wrote: > Hello. > > On 7/2/2015 11:14 AM, Phil Edworthy wrote: > > > Both USB Host (pci0) and Function (USBHS) drivers are enabled. > > The USB PHY driver determines which IP block should be connected > > based on vbus and id signals read via gpios. > > > Note that switch SW5 and SW6 on Koelsch board needs to be set to > > position 3 for this to work. > > [...] > > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts > b/arch/arm/boot/dts/r8a7791-koelsch.dts > > index cffe33f..1bb34d0 100644 > > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > > @@ -615,7 +615,6 @@ > > > > &pci0 { > > status = "okay"; > > - pinctrl-0 = <&usb0_pins>; > > pinctrl-names = "default"; > > As you're removing "pinctrl-0" prop, you also should remove "pinctrl-names". Ok. > > }; > > > > @@ -627,13 +626,15 @@ > > > > &hsusb { > > status = "okay"; > > - pinctrl-0 = <&usb0_pins>; > > Likewise. Sure. > [...] > > WBR, Sergei Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/