From: Arnd Bergmann <arnd@arndb.de>
To: Paul Osmialowski <pawelo@king.net.pl>
Cc: linux-arm-kernel@lists.infradead.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Jiri Slaby <jslaby@suse.cz>, Kumar Gala <galak@codeaurora.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Russell King <linux@arm.linux.org.uk>,
        Stephen Boyd <sboyd@codeaurora.org>, Vinod Koul <vinod.koul@intel.com>,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
        devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Sergei Poselenov <sposelenov@emcraft.com>,
        Paul Bolle <pebolle@tiscali.nl>,
        Jingchang Lu <jingchang.lu@freescale.com>,
        Yuri Tikhonov <yur@emcraft.com>, Rob Herring <r.herring@freescale.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
        Alexander Potashev <aspotashev@emcraft.com>,
        Frank Li <Frank.Li@freescale.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Anson Huang <b20788@freescale.com>
Subject: Re: [PATCH v2 3/9] arm: twr-k70f120m: clock driver for Kinetis SoC
Date: Thu, 02 Jul 2015 14:40:23 +0200
Message-ID: <1861313.aMcV1xHCIq@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <alpine.LNX.2.00.1507021206410.13210@localhost.localdomain>
References: <1435667250-28299-1-git-send-email-pawelo@king.net.pl> <alpine.LNX.2.00.1507011756140.14440@localhost.localdomain> <alpine.LNX.2.00.1507021206410.13210@localhost.localdomain>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 739
Lines: 19

On Thursday 02 July 2015 12:08:39 Paul Osmialowski wrote:
> Nah, I've found this code hard to maintain. I'm attaching simplified 
> version.
> 

Looks better to me, but of course needs full review from the clock
maintainers.

I wonder if you could move out the fixed rate clocks into their own
nodes. Are they actually controlled by the same block? If they are
just fixed, you can use the normal binding for fixed rate clocks
and only describe the clocks that are related to the driver.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/