Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751293AbbGBMx2 (ORCPT ); Thu, 2 Jul 2015 08:53:28 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:48909 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752999AbbGBMxT (ORCPT ); Thu, 2 Jul 2015 08:53:19 -0400 Subject: Re: [PATCH 2/2] ARM: DTS: am437x-sk-evm: Switch using simple-audio-card for audio support To: References: <1435838286-30491-1-git-send-email-peter.ujfalusi@ti.com> <1435838286-30491-3-git-send-email-peter.ujfalusi@ti.com> <20150702122337.GE5837@saruman.tx.rr.com> CC: , , , , From: Peter Ujfalusi Message-ID: <55953421.30009@ti.com> Date: Thu, 2 Jul 2015 15:52:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150702122337.GE5837@saruman.tx.rr.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2962 Lines: 98 On 07/02/2015 03:23 PM, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 02:58:06PM +0300, Peter Ujfalusi wrote: >> The sound support consist only Headset output on the board and can be >> handled by "simple-audio-card" >> >> Signed-off-by: Peter Ujfalusi > > Still works fine: > > Tested-by: Felipe Balbi > > one question though, should Line In be listed below ? Does the board have Line-in? I don't have the board, but I know this patch works on it ;) We only had playback path before also. > Also, unrelated to > $subject, but if I wait for a few seconds between runs of speaker-test > (iow, if I allow mcasp to idle) then I hear a slight chopping sound when > starting, perhaps we're unmuting too early ? Is it only with this patch (via simple-card) or was it the same via the davinci-evm (ti,da830-evm-audio)? -- P?ter > >> --- >> arch/arm/boot/dts/am437x-sk-evm.dts | 30 ++++++++++++++++++++++-------- >> 1 file changed, 22 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts >> index b5de6b0d622c..e09216cb14df 100644 >> --- a/arch/arm/boot/dts/am437x-sk-evm.dts >> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts >> @@ -32,14 +32,26 @@ >> }; >> >> sound { >> - compatible = "ti,da830-evm-audio"; >> - ti,model = "AM437x-SK-EVM"; >> - ti,audio-codec = <&tlv320aic3106>; >> - ti,mcasp-controller = <&mcasp1>; >> - ti,codec-clock-rate = <24000000>; >> - ti,audio-routing = >> - "Headphone Jack", "HPLOUT", >> - "Headphone Jack", "HPROUT"; >> + compatible = "simple-audio-card"; >> + simple-audio-card,name = "AM437x-SK-EVM"; >> + simple-audio-card,widgets = >> + "Headphone", "Headphone Jack"; >> + simple-audio-card,routing = >> + "Headphone Jack", "HPLOUT", >> + "Headphone Jack", "HPROUT"; >> + simple-audio-card,format = "dsp_b"; >> + simple-audio-card,bitclock-master = <&sound_master>; >> + simple-audio-card,frame-master = <&sound_master>; >> + simple-audio-card,bitclock-inversion; >> + >> + simple-audio-card,cpu { >> + sound-dai = <&mcasp1>; >> + }; >> + >> + sound_master: simple-audio-card,codec { >> + sound-dai = <&tlv320aic3106>; >> + system-clock-frequency = <24000000>; >> + }; >> }; >> >> matrix_keypad: matrix_keypad@0 { >> @@ -489,6 +501,7 @@ >> }; >> >> tlv320aic3106: tlv320aic3106@1b { >> + #sound-dai-cells = <0>; >> compatible = "ti,tlv320aic3106"; >> reg = <0x1b>; >> status = "okay"; >> @@ -649,6 +662,7 @@ >> }; >> >> &mcasp1 { >> + #sound-dai-cells = <0>; >> pinctrl-names = "default", "sleep"; >> pinctrl-0 = <&mcasp1_pins>; >> pinctrl-1 = <&mcasp1_pins_sleep>; >> -- >> 2.4.5 >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/