Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753754AbbGBNT5 (ORCPT ); Thu, 2 Jul 2015 09:19:57 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:34449 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322AbbGBNSb (ORCPT ); Thu, 2 Jul 2015 09:18:31 -0400 From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, marc.zyngier@arm.com, alex.williamson@redhat.com, pbonzini@redhat.com, avi.kivity@gmail.com, mtosatti@redhat.com, feng.wu@intel.com, joro@8bytes.org, b.reynal@virtualopensystems.com Cc: linux-kernel@vger.kernel.org, patches@linaro.org Subject: [RFC 17/17] VFIO: platform: add irq bypass producer management Date: Thu, 2 Jul 2015 15:17:27 +0200 Message-Id: <1435843047-6327-18-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1435843047-6327-1-git-send-email-eric.auger@linaro.org> References: <1435843047-6327-1-git-send-email-eric.auger@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5605 Lines: 175 This patch adds irq_bypass_producer registration/unregistration. VFIO producer callbacks are populated: - stop/resume producer simply consist in disabling/enabling the host irq - add/del consumer: basically set the automasked flag to false/true The vfio_platform_device pointer is passed as producer opaque. We also cache the device handle in vfio_platform_device. This makes possible to easily retrieve the vfio_device at registration. Signed-off-by: Eric Auger --- drivers/vfio/platform/vfio_platform_common.c | 2 + drivers/vfio/platform/vfio_platform_irq.c | 83 +++++++++++++++++++++++++++ drivers/vfio/platform/vfio_platform_private.h | 2 + 3 files changed, 87 insertions(+) diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c index 9acfca6..12d4540 100644 --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c @@ -546,6 +546,8 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev, if (!vdev) return -EINVAL; + vdev->dev = dev; + group = iommu_group_get(dev); if (!group) { pr_err("VFIO: No IOMMU group for device %s\n", vdev->name); diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c index f6d83ed..0061e6e 100644 --- a/drivers/vfio/platform/vfio_platform_irq.c +++ b/drivers/vfio/platform/vfio_platform_irq.c @@ -20,6 +20,7 @@ #include #include #include +#include #include "vfio_platform_private.h" @@ -185,6 +186,70 @@ static irqreturn_t vfio_handler(int irq, void *dev_id) return ret; } +static void vfio_platform_stop_producer(struct irq_bypass_producer *prod) +{ + pr_info("%s disable %d\n", __func__, prod->irq); + disable_irq(prod->irq); +} + +static void vfio_platform_resume_producer(struct irq_bypass_producer *prod) +{ + pr_info("%s enable %d\n", __func__, prod->irq); + enable_irq(prod->irq); +} + +static void vfio_platform_add_consumer(struct irq_bypass_producer *prod, + struct irq_bypass_consumer *cons) +{ + int i, ret; + struct vfio_platform_device *vdev = + (struct vfio_platform_device *)prod->opaque; + + pr_info("%s irq=%d gsi =%d\n", __func__, prod->irq, cons->gsi); + + for (i = 0; i < vdev->num_irqs; i++) { + if (vdev->irqs[i].prod == prod) + break; + } + WARN_ON(i == vdev->num_irqs); + + //TODO + /* + * if the IRQ is active at irqchip level or VFIO (auto)masked + * this means the host IRQ is already under injection in the + * guest and this not safe to change the forwarding state at + * that stage. + * It is not possible to differentiate user-space masking + * from auto-masking, leading to possible false detection of + * active state. + */ + prod->active = vfio_external_is_active(prod->vdev, i, 0, 0); + + ret = vfio_external_set_automasked(prod->vdev, i, 0, 0, false); + WARN_ON(ret); +} + +static void vfio_platform_del_consumer(struct irq_bypass_producer *prod, + struct irq_bypass_consumer *cons) +{ + int i; + struct vfio_platform_device *vdev = + (struct vfio_platform_device *)prod->opaque; + + pr_info("%s irq=%d gsi =%d\n", __func__, prod->irq, cons->gsi); + + for (i = 0; i < vdev->num_irqs; i++) { + if (vdev->irqs[i].prod == prod) + break; + } + WARN_ON(i == vdev->num_irqs); + + if (prod->active) + vfio_external_mask(prod->vdev, i, 0, 0); + + vfio_external_set_automasked(prod->vdev, i, 0, 0, true); +} + static int vfio_set_trigger(struct vfio_platform_device *vdev, int index, int fd, irq_handler_t handler) { @@ -192,8 +257,11 @@ static int vfio_set_trigger(struct vfio_platform_device *vdev, int index, struct eventfd_ctx *trigger; int ret; + if (irq->trigger) { free_irq(irq->hwirq, irq); + irq_bypass_unregister_producer(irq->prod); + kfree(irq->prod); kfree(irq->name); eventfd_ctx_put(irq->trigger); irq->trigger = NULL; @@ -225,6 +293,21 @@ static int vfio_set_trigger(struct vfio_platform_device *vdev, int index, return ret; } + irq->prod = kzalloc(sizeof(struct irq_bypass_producer), + GFP_KERNEL); + if (!irq->prod) + return -ENOMEM; + irq->prod->token = (void *)trigger; + irq->prod->irq = irq->hwirq; + irq->prod->vdev = vfio_device_get_from_dev(vdev->dev); + irq->prod->opaque = (void *)vdev; + irq->prod->add_consumer = vfio_platform_add_consumer; + irq->prod->del_consumer = vfio_platform_del_consumer; + irq->prod->stop_producer = vfio_platform_stop_producer; + irq->prod->resume_producer = vfio_platform_resume_producer; + ret = irq_bypass_register_producer(irq->prod); + WARN_ON(ret); + if (!irq->masked) enable_irq(irq->hwirq); diff --git a/drivers/vfio/platform/vfio_platform_private.h b/drivers/vfio/platform/vfio_platform_private.h index 5f46c68..1255306 100644 --- a/drivers/vfio/platform/vfio_platform_private.h +++ b/drivers/vfio/platform/vfio_platform_private.h @@ -38,6 +38,7 @@ struct vfio_platform_irq { struct virqfd *unmask; struct virqfd *mask; irqreturn_t (*handler)(int irq, void *dev_id); + struct irq_bypass_producer *prod; }; struct vfio_platform_region { @@ -57,6 +58,7 @@ struct vfio_platform_device { u32 num_irqs; int refcnt; struct mutex igate; + struct device *dev; /* * These fields should be filled by the bus specific binder -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/