Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753024AbbGBNhr (ORCPT ); Thu, 2 Jul 2015 09:37:47 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:43462 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119AbbGBNhh (ORCPT ); Thu, 2 Jul 2015 09:37:37 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Thu, 02 Jul 2015 15:34:58 +0200 From: Stefan Agner To: Cory Tusar Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, shawnguo@kernel.org, kernel@pengutronix.de, han.xu@freescale.com, dwmw2@infradead.org, computersforpeace@gmail.com, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, andrew@lunn.ch Subject: Re: [RFC PATCH 1/7] ARM: dts: vf610: Add missing QuadSPI register mapping and names. In-Reply-To: <1435782010-9809-3-git-send-email-cory.tusar@pid1solutions.com> References: <1435782010-9809-1-git-send-email-cory.tusar@pid1solutions.com> <1435782010-9809-3-git-send-email-cory.tusar@pid1solutions.com> Message-ID: User-Agent: Roundcube Webmail/1.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 35 On 2015-07-01 22:20, Cory Tusar wrote: > Both 'reg' and 'reg-names' are required properties according to binding > documentation, and both should contain two items. > > Signed-off-by: Cory Tusar > --- > arch/arm/boot/dts/vfxxx.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 4aa3351..089a263 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -242,7 +242,8 @@ > #address-cells = <1>; > #size-cells = <0>; > compatible = "fsl,vf610-qspi"; > - reg = <0x40044000 0x1000>; > + reg = <0x40044000 0x1000>, <0x20000000 0x10000000>; > + reg-names = "QuadSPI", "QuadSPI-memory"; > interrupts = <24 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&clks VF610_CLK_QSPI0_EN>, > <&clks VF610_CLK_QSPI0>; Hm, this seem to have been wrong since the beginning... Acked-by: Stefan Agner -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/