Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbbGBNhE (ORCPT ); Thu, 2 Jul 2015 09:37:04 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:53386 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbbGBNgz (ORCPT ); Thu, 2 Jul 2015 09:36:55 -0400 Message-ID: <55953E71.4070109@atmel.com> Date: Thu, 2 Jul 2015 15:36:49 +0200 From: Cyrille Pitchen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnd Bergmann CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style References: <9f0f19d2fe05ea95572b467ec49ecd11389e3be9.1435672649.git.cyrille.pitchen@atmel.com> <11308515.NsBzDiA1lH@wuerfel> In-Reply-To: <11308515.NsBzDiA1lH@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 32 Hi Arnd, I've just sent a new series of patches to remove all those macros. By the way, the patch dedicated to this update was created using coccinelle. Based on Alexandre comment, I leave __raw_writel() and __raw_readl() for now. Best Regards, Cyrille Le 30/06/2015 22:28, Arnd Bergmann a ?crit : > On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote: >> +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_CR) >> +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_US_MR) >> +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + ATMEL_US_MR) >> +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + ATMEL_US_IER) >> > > How about removing these macros entirely? I'm not aware of other drivers > doing it like this, and it does not seem to add any value? > > At the same time, you could use readl_relaxed() to make the driver > endian-safe. > > Arnd > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/